Change debug() method to the new window.DUMP in icc*.js

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: frsela, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

Details

(Whiteboard: QARegressExclude)

Attachments

(1 attachment)

Change debug() calls into ICC classes to use window.DUMP
Depends on: 881672
Created attachment 764760 [details]
Removed debug() method in favor of the new shared window.DUMP method
Attachment #764760 - Flags: review?(kaze)
Attachment #764760 - Flags: review?(kaze) → review+
Rebased and landed: https://github.com/mozilla-b2g/gaia/commit/08c9cf50fe1d2e8bbb3931d61e0a30c6a1bc6b6c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Can we bolster this, dump() and test-wise?  This functionality was broken due to bug 886844, and halted development/QA for the better part of a day :-(
(In reply to Stephen Donner [:stephend] from comment #3)
> Can we bolster this, dump() and test-wise?  This functionality was broken
> due to bug 886844, and halted development/QA for the better part of a day :-(

Hi Stephen,

886844 error was my fault (sorry for that), I forgot adding one file to the commit so the resource generation file went to the settings folder instead system one.

But I think this is completly different from the previous one. In this case, we developed a shared library for dumping to the console and this can be enable/disable from the settings app.
Nominating to leo? in order to leave STK code refactoring completed. All STK commands moved from settings to system (Bug 875679) are using window.DUMP but the ones remaining in settings still use debug (), with this bug all STK commands (system, settings) will use the new window.DUMP.
Blocks: 875679
blocking-b2g: --- → leo?
blocking-b2g: leo? → leo+
I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 08c9cf50fe1d2e8bbb3931d61e0a30c6a1bc6b6c
  <RESOLVE MERGE CONFLICTS>
  git commit
Flags: needinfo?(nobody)
Fixed: https://github.com/mozilla-b2g/gaia/commit/0dc11e46ce31b68c01ab3cf454b558c7abecd430
Flags: needinfo?(nobody)
Hi John,

Could you please help us with the uplift to v1-train again?. Thanks!.
Flags: needinfo?(jhford)
v1.1.0hd: 0dc11e46ce31b68c01ab3cf454b558c7abecd430
status-b2g-v1.1hd: --- → fixed
Flags: needinfo?(jhford)
(In reply to Noemí Freire (:noemi) from comment #8)
> Hi John,
> 
> Could you please help us with the uplift to v1-train again?. Thanks!.

That is the commit in comment 7, which was merged onto v1.1.0hd
status-b2g18: --- → fixed
(In reply to John Ford [:jhford] -- please use 'needinfo?' instead of a CC from comment #10)
> (In reply to Noemí Freire (:noemi) from comment #8)
> > Hi John,
> > 
> > Could you please help us with the uplift to v1-train again?. Thanks!.
> 
> That is the commit in comment 7, which was merged onto v1.1.0hd

OK, many thanks.

Updated

4 years ago
Whiteboard: QARegressExclude
You need to log in before you can comment on or make changes to this bug.