884745 - Change debug() method to the new window.DUMP in icc*.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Change debug() calls into ICC classes to use window.DUMP

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Removed debug() method in favor of the new shared window.DUMP method

Comment 2

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Rebased and landed: https://github.com/mozilla-b2g/gaia/commit/08c9cf50fe1d2e8bbb3931d61e0a30c6a1bc6b6c

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Can we bolster this, dump() and test-wise?  This functionality was broken due to bug 886844, and halted development/QA for the better part of a day :-(

Comment 4

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Stephen Donner [:stephend] from comment #3)
> Can we bolster this, dump() and test-wise?  This functionality was broken
> due to bug 886844, and halted development/QA for the better part of a day :-(

Hi Stephen,

886844 error was my fault (sorry for that), I forgot adding one file to the commit so the resource generation file went to the settings folder instead system one.

But I think this is completly different from the previous one. In this case, we developed a shared library for dumping to the console and this can be enable/disable from the settings app.

Comment 5

[Noemí Freire (:noemi)]

Nominating to leo? in order to leave STK code refactoring completed. All STK commands moved from settings to system (Bug 875679) are using window.DUMP but the ones remaining in settings still use debug (), with this bug all STK commands (system, settings) will use the new window.DUMP.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 08c9cf50fe1d2e8bbb3931d61e0a30c6a1bc6b6c
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 7

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Fixed: https://github.com/mozilla-b2g/gaia/commit/0dc11e46ce31b68c01ab3cf454b558c7abecd430

Comment 8

[Noemí Freire (:noemi)]

Hi John,

Could you please help us with the uplift to v1-train again?. Thanks!.

Comment 9

[Gareth Aye [:gaye] (back from PTO)]

v1.1.0hd: 0dc11e46ce31b68c01ab3cf454b558c7abecd430

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Noemí Freire (:noemi) from comment #8)
> Hi John,
> 
> Could you please help us with the uplift to v1-train again?. Thanks!.

That is the commit in comment 7, which was merged onto v1.1.0hd

Comment 11

[Noemí Freire (:noemi)]

(In reply to John Ford [:jhford] -- please use 'needinfo?' instead of a CC from comment #10)
> (In reply to Noemí Freire (:noemi) from comment #8)
> > Hi John,
> > 
> > Could you please help us with the uplift to v1-train again?. Thanks!.
> 
> That is the commit in comment 7, which was merged onto v1.1.0hd

OK, many thanks.