884775 - Support forum doesn't validate

Status: RESOLVED FIXED

(support.mozilla.org :: Questions, task, P4)

Description

[Scoobidiver (away)]

There are 3 errors.

See http://validator.w3.org/check?uri=https%3A%2F%2Fsupport.mozilla.org%2Fen-US%2Fquestions&charset=%28detect+automatically%29&doctype=Inline&group=0&user-agent=W3C_Validator%2F1.3+http%3A%2F%2Fvalidator.w3.org%2Fservices

Comment 1

[Taygun]

I would like to work on this bug.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Taygun from comment #1)
> I would like to work on this bug.

go for it! let me know if you have any questions.

Comment 3

[Joshua Smith [:joshua-s]]

Assigning to Taygun!

Comment 4

[Taygun]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #2)
> (In reply to Taygun from comment #1)
> > I would like to work on this bug.
> 
> go for it! let me know if you have any questions.

I am not sure how to solve the first validation error (Attribute required not allowed on element input at this point). Can I get a hint, please?

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Taygun from comment #4)
> (In reply to Ricky Rosario [:rrosario, :r1cky] from comment #2)
> I am not sure how to solve the first validation error (Attribute required
> not allowed on element input at this point). Can I get a hint, please?

This means there probably is a <input type="hidden" required="required"/> or similar on the page. I am pretty sure this involves tweaking our monkeypatch for adding the required attributes to stop adding them for hidden inputs:

https://github.com/mozilla/kitsune/blob/master/kitsune/sumo/monkeypatch.py#L11

Comment 6

[Taygun]

I am not sure if i have to post this in here, but i made a pull request for this bug. https://github.com/mozilla/kitsune/pull/1668

Comment 7

[Joshua Smith [:joshua-s]]

You need to put attach a link to the patch to this bug.  E.g. create a text attachment of type patch, and set the description and content to https://github.com/mozilla/kitsune/pull/1668.  Also, set the r flag to "?" because you will need the patch reviewed.

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

Actually, the pull request is fine. That's how we do it for sumo-dev. Thanks!

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/65c7d4a7dbfe624418397aa75d34ae8f908f54a0


Thanks Taygun!

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod. Looks good:

http://validator.w3.org/check?uri=https%3A%2F%2Fsupport.mozilla.org%2Fen-US%2Fquestions&charset=%28detect+automatically%29&doctype=Inline&group=0&user-agent=W3C_Validator%2F1.3+http%3A%2F%2Fvalidator.w3.org%2Fservices