884796 - browser_inspector_scrolling.js fails on HiDPI

Status: RESOLVED WORKSFORME

(Core :: Widget, defect)

Description

[Victor Porof [:vporof][:vp]]

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_scrolling.js | inspected iframe scrolled - Got 25, expected 50

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

This should probably be fixed in WinMouseScrollHandler.cpp MouseScrollHandler::SynthesizeNativeMouseScrollEvent.

aDelta should be doubled for HiDPI screens.

Moving to Core::Widget

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Scale deltas in EventUtils.js::synthesizeWheel() on HiDPI screens

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #1)
> This should probably be fixed in WinMouseScrollHandler.cpp
> MouseScrollHandler::SynthesizeNativeMouseScrollEvent.
> 
> aDelta should be doubled for HiDPI screens.
> 
> Moving to Core::Widget

Actually, EventUtils.js::synthesizeWheel() seems like a more appropriate place to fix this.

Very simple fix... Robcee is a testing peer so I think he can review this.

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 8372874 [details] [diff] [review]
Scale deltas in EventUtils.js::synthesizeWheel() on HiDPI screens

Review of attachment 8372874 [details] [diff] [review]:
-----------------------------------------------------------------

nice

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Try:
https://tbpl.mozilla.org/?tree=Try&rev=d52b797fc3fe

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Try:
https://tbpl.mozilla.org/?tree=Try&rev=b9ee19d0e73f

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://hg.mozilla.org/integration/fx-team/rev/8bf094fdb4f0

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Bounced https://hg.mozilla.org/integration/fx-team/rev/476e861951fd

Seems like we are best only adjusting these values only for retina displays. At the moment they are also changed when the text is zoomed.

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

This is no longer an issue.