Closed
Bug 884810
Opened 11 years ago
Closed 11 years ago
ctx.ready does not register event listener target if available
Categories
(L20n :: JS Library, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
1.0
People
(Reporter: zbraniecki, Assigned: zbraniecki)
Details
Attachments
(2 files)
|
464 bytes,
patch
|
stas
:
review+
|
Details | Diff | Splinter Review |
|
1.89 KB,
patch
|
Details | Diff | Splinter Review |
If at the time when programmer calls ctx.ready() the context is available, it will only fire the callback and exit. In result the eventListener onready will never be set and in result the callback will never be executed after locale switch.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → 1.0
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #764733 -
Flags: review?(stas)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #764733 -
Attachment is patch: true
Attachment #764733 -
Attachment mime type: text/x-patch → text/plain
|
||
Comment 2•11 years ago
|
||
Comment on attachment 764733 [details] [diff] [review] patch Review of attachment 764733 [details] [diff] [review]: ----------------------------------------------------------------- Can you add a few tests please?
Attachment #764733 -
Flags: review?(stas) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://github.com/l20n/l20n.js/commit/11b7a4d546248089003d6d29b1f09651ec994db4
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
|
Assignee | |
Comment 5•11 years ago
|
||
https://github.com/l20n/l20n.js/commit/72224662331d8c9e51eb99e7ed403904fd4a7515
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•