The default bug view has changed. See this FAQ.

Move EXTRA_JS_MODULES to moz.build in c-c

RESOLVED FIXED in Thunderbird 24.0

Status

MailNews Core
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jcranmer, Assigned: jcranmer)

Tracking

(Blocks: 1 bug)

unspecified
Thunderbird 24.0
x86_64
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 764740 [details] [diff] [review]
Do all the things

This also moves JS_MODULES_PATH, fixes the JS_MODULES_PATH variable to be relative to FINAL_TARGET instead of absolute, and undoes libs:: $(INSTALL) rules in two Makefiles where JS_MODULES_PATH would have been better used.
Attachment #764740 - Flags: review?(mbanner)
(Assignee)

Comment 1

4 years ago
Created attachment 765023 [details] [diff] [review]
Updated patch

Let's try one that doesn't completely and horribly break everything this time.
Attachment #764740 - Attachment is obsolete: true
Attachment #764740 - Flags: review?(mbanner)
Attachment #765023 - Flags: review?(mbanner)
Comment on attachment 765023 [details] [diff] [review]
Updated patch

Review of attachment 765023 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the one issue fixed.

::: mailnews/db/gloda/modules/moz.build
@@ +22,5 @@
> +    'indexer.js',
> +    'log4moz.js',
> +    'mimeTypeCategories.js',
> +    'mimemsg.js',
> +    'moz.build',

moz.build?
Attachment #765023 - Flags: review?(mbanner) → review+
(Assignee)

Comment 3

4 years ago
(In reply to Mark Banner (:standard8) from comment #2)
> moz.build?

That's what I get for generating this list by copying "vim mailnews/db/gloda/modules" :-)
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/comm-central/rev/993bb2a45132
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.