The default bug view has changed. See this FAQ.

Align navigator.vibrate with the spec

RESOLVED FIXED in mozilla27

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: bz, Assigned: drexler)

Tracking

({dev-doc-complete})

Trunk
mozilla27
dev-doc-complete
Points:
---

Firefox Tracking Flags

(relnote-firefox -)

Details

Attachments

(1 attachment)

Per spec, we should return false when the list is too long or has too-large entries.  We're throwing instead.
I think returning false is better than throwing, we should fix our implementation.

Justin, do you have cycles to take this?
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
I'd hate to deprive someone of a valuable learning experience; do we have anyone new to take this?  Otherwise sure, it's not a bug deal
Either way, please don't touch this code until I land bug 838146!
Depends on: 838146

Comment 4

4 years ago
(In reply to Justin Lebar [:jlebar] from comment #2)
> I'd hate to deprive someone of a valuable learning experience; do we have
> anyone new to take this?  Otherwise sure, it's not a bug deal
CC'ing jdm

Comment 5

4 years ago
Maria, this one is a simple change that could interest you.
Keywords: dev-doc-needed
(Assignee)

Comment 6

4 years ago
Created attachment 809531 [details] [diff] [review]
Impl
Assignee: nobody → andrew.quartey
Attachment #809531 - Flags: review?(justin.lebar+bug)
I'm not sure if Justin is still available for reviews...
Attachment #809531 - Flags: review?(justin.lebar+bug) → review?(bugs)
Comment on attachment 809531 [details] [diff] [review]
Impl

https://tbpl.mozilla.org/?tree=Try&rev=7b2ca3c3e626
Attachment #809531 - Flags: review?(bugs) → review+
(Assignee)

Comment 9

4 years ago
inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/bbf7f7deb76f
https://hg.mozilla.org/mozilla-central/rev/bbf7f7deb76f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
relnote-firefox: --- → ?
teoli, 

Seems to impact firefox OS only ? Unclear why would release note it on desktop/android .
relnote-firefox: ? → -
:bajaj, it impacts Firefox for Android too (but not Desktop as it has no vibrating device). Can anyone else comfirm/infirm? Andrew?
Flags: needinfo?(andrew.quartey)
(Assignee)

Comment 13

4 years ago
(In reply to Jean-Yves Perrier [:teoli] from comment #12)
> :bajaj, it impacts Firefox for Android too (but not Desktop as it has no
> vibrating device). Can anyone else comfirm/infirm? Andrew?

Unless, i'm mistaken this should be for firefox OS and Android only, right Boris?
Flags: needinfo?(andrew.quartey)
(Assignee)

Comment 14

4 years ago
Do see comment 12.
Flags: needinfo?(bzbarsky)
We do expose vibrate() on desktop too and this affects the behavior there.
Flags: needinfo?(bzbarsky)
Indeed.  There is no vibration on desktop, but the API is present, and the behavior is detectable by the web page: it gets an exception from a call that should not, per spec, throw one.  Which is obviously less than ideal.
Doc updated: https://developer.mozilla.org/en-US/Firefox/Releases/27
and
https://developer.mozilla.org/en-US/docs/Web/API/Navigator.vibrate
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.