Per spec, we should return false when the list is too long or has too-large entries. We're throwing instead.
I think returning false is better than throwing, we should fix our implementation. Justin, do you have cycles to take this?
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
I'd hate to deprive someone of a valuable learning experience; do we have anyone new to take this? Otherwise sure, it's not a bug deal
(In reply to Justin Lebar [:jlebar] from comment #2) > I'd hate to deprive someone of a valuable learning experience; do we have > anyone new to take this? Otherwise sure, it's not a bug deal CC'ing jdm
Maria, this one is a simple change that could interest you.
Assignee: nobody → andrew.quartey
Attachment #809531 - Flags: review?(justin.lebar+bug)
I'm not sure if Justin is still available for reviews...
Attachment #809531 - Flags: review?(justin.lebar+bug) → review?(bugs)
Comment on attachment 809531 [details] [diff] [review] Impl https://tbpl.mozilla.org/?tree=Try&rev=7b2ca3c3e626
Attachment #809531 - Flags: review?(bugs) → review+
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
teoli, Seems to impact firefox OS only ? Unclear why would release note it on desktop/android .
relnote-firefox: ? → -
:bajaj, it impacts Firefox for Android too (but not Desktop as it has no vibrating device). Can anyone else comfirm/infirm? Andrew?
(In reply to Jean-Yves Perrier [:teoli] from comment #12) > :bajaj, it impacts Firefox for Android too (but not Desktop as it has no > vibrating device). Can anyone else comfirm/infirm? Andrew? Unless, i'm mistaken this should be for firefox OS and Android only, right Boris?
Do see comment 12.
We do expose vibrate() on desktop too and this affects the behavior there.
Indeed. There is no vibration on desktop, but the API is present, and the behavior is detectable by the web page: it gets an exception from a call that should not, per spec, throw one. Which is obviously less than ideal.
Doc updated: https://developer.mozilla.org/en-US/Firefox/Releases/27 and https://developer.mozilla.org/en-US/docs/Web/API/Navigator.vibrate
Keywords: dev-doc-needed → dev-doc-complete
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.