884935 - Align navigator.vibrate with the spec

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Per spec, we should return false when the list is too long or has too-large entries.  We're throwing instead.

Comment 1

[Mounir Lamouri (:mounir)]

I think returning false is better than throwing, we should fix our implementation.

Justin, do you have cycles to take this?

Comment 2

[Justin Lebar (not reading bugmail)]

I'd hate to deprive someone of a valuable learning experience; do we have anyone new to take this?  Otherwise sure, it's not a bug deal

Comment 3

[Boris Zbarsky [:bzbarsky]]

Either way, please don't touch this code until I land bug 838146!

Comment 4

[David Bruant]

(In reply to Justin Lebar [:jlebar] from comment #2)
> I'd hate to deprive someone of a valuable learning experience; do we have
> anyone new to take this?  Otherwise sure, it's not a bug deal
CC'ing jdm

Comment 5

[Josh Matthews [:jdm]]

Maria, this one is a simple change that could interest you.

Comment 6

[Andrew Quartey [:drexler]]

Attachment: Impl

Comment 7

[(no longer active)]

I'm not sure if Justin is still available for reviews...

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 809531 [details] [diff] [review]
Impl

https://tbpl.mozilla.org/?tree=Try&rev=7b2ca3c3e626

Comment 9

[Andrew Quartey [:drexler]]

inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/bbf7f7deb76f

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bbf7f7deb76f

Comment 11

[bhavana bajaj [:bajaj]]

teoli, 

Seems to impact firefox OS only ? Unclear why would release note it on desktop/android .

Comment 12

[Jean-Yves Perrier [:teoli]]

:bajaj, it impacts Firefox for Android too (but not Desktop as it has no vibrating device). Can anyone else comfirm/infirm? Andrew?

Comment 13

[Andrew Quartey [:drexler]]

(In reply to Jean-Yves Perrier [:teoli] from comment #12)
> :bajaj, it impacts Firefox for Android too (but not Desktop as it has no
> vibrating device). Can anyone else comfirm/infirm? Andrew?

Unless, i'm mistaken this should be for firefox OS and Android only, right Boris?

Comment 14

[Andrew Quartey [:drexler]]

Do see comment 12.

Comment 15

[Olli Pettay [:smaug][[e-mail]]]

We do expose vibrate() on desktop too and this affects the behavior there.

Comment 16

[Boris Zbarsky [:bzbarsky]]

Indeed.  There is no vibration on desktop, but the API is present, and the behavior is detectable by the web page: it gets an exception from a call that should not, per spec, throw one.  Which is obviously less than ideal.

Comment 17

[Jean-Yves Perrier [:teoli]]

Doc updated: https://developer.mozilla.org/en-US/Firefox/Releases/27
and
https://developer.mozilla.org/en-US/docs/Web/API/Navigator.vibrate