884944 - [socorro-crashstats] Colors in /daily once again don't match

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Robert Kaiser]

https://crash-stats-django.mozilla.org/daily?p=Firefox once again has a mismatch in colors between the graph and the table headers, it looks like the colors are assigned in exactly opposite order to each other in those two sections - 24.0a1 should be blue and 21.0 purple in the table as well (the other two are swapped as well, so I think it's just the order that is swapped).

Feels to me like we had exactly that already some time earlier...

Bug 842720 maybe? I see that was fixed by Rob, so CCing him.

Comment 1

[Robert Helmer [:rhelmer]]

I think this is a regression for bug 847293

Comment 2

[Brandon Savage [:brandon]]

This is probably a regression. I believe I reversed the list/DotDict to get the versions in the right order, which may have exactly reversed the coloring.

Comment 3

[Robert Kaiser]

Rob, what info do you want from me with that ni?

Comment 4

[Robert Helmer [:rhelmer]]

(In reply to Robert Kaiser (:[e-mail]) from comment #3)
> Rob, what info do you want from me with that ni?

Oops was meant for brandon, sorry!

Comment 5

[Robert Kaiser]

https://crash-stats-django.mozilla.org/daily?form_selection=by_version&p=Firefox&v=22.0b4&v=22.0b6&v=22.0b5&v=22.0b3&hang_type=any&os=Windows&os=Mac+OS+X&os=Linux&date_range_type=report&date_start=2013-06-01&date_end=2013-06-24&submit=Generate has the colors not even in reverse order, they don't match in either direction.

Comment 7

[Asa Dotzler [:asa]]

This has now twice caused me to misinterpret results causing a moderate waste of time.  What's the priority and the plan for fixing?

Comment 8

[Robert Helmer [:rhelmer]]

Brandon, are you working on this one?

Comment 9

[Peter Bengtsson [:peterbe]]

PR: https://github.com/mozilla/socorro/pull/1419

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/9a11802fc658ae11a2dbd2ac2385f322c8ad66f0
fixes bug 884944 - Colors in /daily once again don't match, r=brandonsavage

Comment 11

[Matt Brandt [:mbrandt]]

QA verified on stage - graph colors and the graph legend match.

https://crash-stats.allizom.org/daily?form_selection=by_version&p=Firefox&v=24.0a2&v=26.0a1&v=23.0.1&v=23.0&hang_type=any&os=Windows&os=Mac+OS+X&os=Linux&date_range_type=report&date_start=2013-08-01&date_end=2013-08-27&submit=Generate

Comment 12

[Robert Kaiser]

Peter fixed this, no info needed from Brandon any more ;-)