Change - Update the url link to privacy policy webpage

VERIFIED FIXED

Status

P1
normal
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: ywang, Assigned: jimm)

Tracking

Trunk
x86
Windows 8.1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: feature=change c=tbd u=tbd p=1)

Attachments

(1 attachment, 1 obsolete attachment)

I walked through metro build with Alina from privacy team today.

We need to update the privacy policy link in the "About" flyout.
It should point to the Mozilla Firefox one: http://www.mozilla.org/en-US/legal/privacy/firefox.html

Thanks!

Updated

5 years ago
Blocks: 859003
Whiteboard: feature=change c=tbd u=tbd p=0
(Assignee)

Updated

5 years ago
Priority: -- → P1
(Assignee)

Comment 1

5 years ago
Created attachment 765317 [details] [diff] [review]
link change
Assignee: nobody → jmathies
Attachment #765317 - Flags: review?(ywang)
(Assignee)

Comment 2

5 years ago
Could you ask Alina if this is localized? I think we'll want to pull this from a localized resource.
(Assignee)

Comment 3

5 years ago
Created attachment 765320 [details] [diff] [review]
localized link change

I'm guessing it is from the en-US path. In which case we want a localized version.
Attachment #765317 - Attachment is obsolete: true
Attachment #765317 - Flags: review?(ywang)
Attachment #765320 - Flags: review?(ywang)

Updated

5 years ago
Blocks: 875026
No longer blocks: 859003
QA Contact: jbecerra
Whiteboard: feature=change c=tbd u=tbd p=0 → feature=change c=tbd u=tbd p=1

Updated

5 years ago
Status: NEW → ASSIGNED
(In reply to Jim Mathies [:jimm] from comment #2)
> Could you ask Alina if this is localized? I think we'll want to pull this
> from a localized resource.

Asked in Bug885129. Should hear back from her soon. 

I walked through the public policy page myself. It seems like there is no localized version yet.

Updated

5 years ago
Depends on: 885129

Updated

5 years ago
Blocks: 882638
No longer blocks: 875026
(Assignee)

Comment 5

5 years ago
(In reply to Yuan Wang(:Yuan) – Firefox UX Team from comment #4)
> (In reply to Jim Mathies [:jimm] from comment #2)
> > Could you ask Alina if this is localized? I think we'll want to pull this
> > from a localized resource.
> 
> Asked in Bug885129. Should hear back from her soon. 
> 
> I walked through the public policy page myself. It seems like there is no
> localized version yet.

I did a little testing - we don't localize this page yet but the localized links all redirect to to the en-US page. So looks like plan on localizing it but haven't gotten around to doing it. Therefore I think this patch is safe.
(Assignee)

Updated

5 years ago
Attachment #765320 - Flags: review?(ywang) → review?(jwilde)
Comment on attachment 765320 [details] [diff] [review]
localized link change

Review of attachment 765320 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/browser.js
@@ +973,5 @@
>    },
>  
>    onAboutPolicyClick: function() {
>      FlyoutPanelsUI.hide();
> +    let linkStr = Services.urlFormatter.formatURLPref("app.privacyURL")

Nits: missing semicolon.
Attachment #765320 - Flags: review?(jwilde) → review+

Updated

5 years ago
No longer depends on: 885129
See Also: → bug 885129

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/54c483d4bbf6
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Windows NT 6.2; rv:25.0) Gecko/20130715 Firefox/25.0

Verified the fix on latest Nightly build: the privacy policy link from the About flyout redirects now to www.mozilla.org/en-US/legal/privacy/firefox.html
Status: RESOLVED → VERIFIED
Went through the following "Change" for iteration #12 without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-15-03-02-03-mozilla-central/

- Went through the original test case outlined in comment #0 without any issues
- Went through the test case added in comment #9 without any issues
- Also ensured that the correct website is being loaded in Filled View
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.