885005 - Change - Update the url link to privacy policy webpage

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Flyouts, defect, P1)

Description

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

I walked through metro build with Alina from privacy team today.

We need to update the privacy policy link in the "About" flyout.
It should point to the Mozilla Firefox one: http://www.mozilla.org/en-US/legal/privacy/firefox.html

Thanks!

Comment 1

[Jim Mathies [:jimm]]

Attachment: link change

Comment 2

[Jim Mathies [:jimm]]

Could you ask Alina if this is localized? I think we'll want to pull this from a localized resource.

Comment 3

[Jim Mathies [:jimm]]

Attachment: localized link change

I'm guessing it is from the en-US path. In which case we want a localized version.

Comment 4

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

(In reply to Jim Mathies [:jimm] from comment #2)
> Could you ask Alina if this is localized? I think we'll want to pull this
> from a localized resource.

Asked in Bug885129. Should hear back from her soon. 

I walked through the public policy page myself. It seems like there is no localized version yet.

Comment 5

[Jim Mathies [:jimm]]

(In reply to Yuan Wang(:Yuan) – Firefox UX Team from comment #4)
> (In reply to Jim Mathies [:jimm] from comment #2)
> > Could you ask Alina if this is localized? I think we'll want to pull this
> > from a localized resource.
> 
> Asked in Bug885129. Should hear back from her soon. 
> 
> I walked through the public policy page myself. It seems like there is no
> localized version yet.

I did a little testing - we don't localize this page yet but the localized links all redirect to to the en-US page. So looks like plan on localizing it but haven't gotten around to doing it. Therefore I think this patch is safe.

Comment 6

[Jonathan Wilde [:jwilde]]

Comment on attachment 765320 [details] [diff] [review]
localized link change

Review of attachment 765320 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/browser.js
@@ +973,5 @@
>    },
>  
>    onAboutPolicyClick: function() {
>      FlyoutPanelsUI.hide();
> +    let linkStr = Services.urlFormatter.formatURLPref("app.privacyURL")

Nits: missing semicolon.

Comment 7

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/54c483d4bbf6

Thanks!

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/54c483d4bbf6

Comment 9

[Mihaela Velimiroviciu (:mihaelav)]

Mozilla/5.0 (Windows NT 6.2; rv:25.0) Gecko/20130715 Firefox/25.0

Verified the fix on latest Nightly build: the privacy policy link from the About flyout redirects now to www.mozilla.org/en-US/legal/privacy/firefox.html

Comment 10

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Change" for iteration #12 without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-15-03-02-03-mozilla-central/

- Went through the original test case outlined in comment #0 without any issues
- Went through the test case added in comment #9 without any issues
- Also ensured that the correct website is being loaded in Filled View