885069 - Australis: WinXP: too much padding between tabs and menubar when customizing with sizemode=normal

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

too much padding-top when in normal mode

https://www.flickr.com/photos/12814025@N06/9075989856/in/set-72157634194258154

Comment 1

[Justin Dolske [:Dolske]]

Every XP window does this is customize mode? Looks significantly broken.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Investigating.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Check out these screenshots:

https://www.flickr.com/photos/12814025@N06/9073760777/in/set-72157634194258154/lightbox/
https://www.flickr.com/photos/12814025@N06/9075989856/in/set-72157634194258154/lightbox/
https://www.flickr.com/photos/12814025@N06/9075989412/in/set-72157634194258154/lightbox/
https://www.flickr.com/photos/12814025@N06/9073758905/in/set-72157634194258154/lightbox/

In all of them, the padding between the menubar and the tabstrip is too large. I assume that's what this bug is about.

Unfortunately, I don't seem to be able to reproduce these conditions. Here's what I'm getting when I enter customize mode on XP:

http://i.imgur.com/dydd7A4.png

It's still fugly due to the titlebar being stretched too far down in the background, but that's a separate issue.

Is anybody else able to get that large padding between the tabstrip and the menu on XP?

Comment 4

[:Gijs (he/him)]

(In reply to Mike Conley (:mconley) - mostly gone until July 8 from comment #3)
> Check out these screenshots:
> 
> https://www.flickr.com/photos/12814025@N06/9073760777/in/set-
> 72157634194258154/lightbox/
> https://www.flickr.com/photos/12814025@N06/9075989856/in/set-
> 72157634194258154/lightbox/
> https://www.flickr.com/photos/12814025@N06/9075989412/in/set-
> 72157634194258154/lightbox/
> https://www.flickr.com/photos/12814025@N06/9073758905/in/set-
> 72157634194258154/lightbox/
> 
> In all of them, the padding between the menubar and the tabstrip is too
> large. I assume that's what this bug is about.
> 
> Unfortunately, I don't seem to be able to reproduce these conditions. Here's
> what I'm getting when I enter customize mode on XP:
> 
> http://i.imgur.com/dydd7A4.png
> 
> It's still fugly due to the titlebar being stretched too far down in the
> background, but that's a separate issue.
> 
> Is anybody else able to get that large padding between the tabstrip and the
> menu on XP?

I think this is bug 886030, (see STR there) and I'll put up a patch for that one in my morning. I don't know in what sequence Matt's screenshot tool enables/disables the menubar and so on, and if that can explain what we were seeing here, but it's definitely part of how I can reproduce this...

Comment 5

[Matthew N. [:MattN]]

(In reply to :Gijs Kruitbosch from comment #4)
> I don't know in what sequence Matt's screenshot tool
> enables/disables the menubar and so on

The order matches the modes specified in the filename.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

So Gijs had some STR for the customization mode case:

1) With menubar enabled, enter customization mode
2) Right-click on the menubar and choose to hide it

That case seems to have been resolved by Bug 886030.

Does anybody have STR for the non-customization mode case?

Comment 7

[:Gijs (he/him)]

(In reply to Matthew N. [:MattN] from comment #5)
> (In reply to :Gijs Kruitbosch from comment #4)
> > I don't know in what sequence Matt's screenshot tool
> > enables/disables the menubar and so on
> 
> The order matches the modes specified in the filename.

Does it restart with a clean profile for each screenshot? Also, can we easily rerun the WinXP Luna restored mode screenshots against current tip?

Comment 8

[Matthew N. [:MattN]]

(In reply to :Gijs Kruitbosch from comment #7)
> (In reply to Matthew N. [:MattN] from comment #5)
> > (In reply to :Gijs Kruitbosch from comment #4)
> > > I don't know in what sequence Matt's screenshot tool
> > > enables/disables the menubar and so on
> > 
> > The order matches the modes specified in the filename.
> 
> Does it restart with a clean profile for each screenshot?
No

> Also, can we easily rerun the WinXP Luna restored mode screenshots against current tip?

Yep. See https://github.com/mnoorenberghe/mozscreenshots I don't have time to do this today but I can help.

Comment 9

[:Gijs (he/him)]

(In reply to Matthew N. [:MattN] from comment #8)
> (In reply to :Gijs Kruitbosch from comment #7)
> > Also, can we easily rerun the WinXP Luna restored mode screenshots against current tip?
> 
> Yep. See https://github.com/mnoorenberghe/mozscreenshots I don't have time
> to do this today but I can help.

I don't have a python env setup on my XP vm, so if you have time to do this today (just for XP luna) that'd be awesome. I suspect this is now fixed... but can't be sure without the screenshots (as I suspect that the turning the menubar on/off in/out of customization mode stuff will have affected the screenshots, and we should be good now).

If not, I can look at it tomorrow.

Comment 10

[Matthew N. [:MattN]]

Attachment: Screenshot with no large gap between the menubar and tabs

A new Luna Blue set is at https://www.flickr.com/photos/12814025@N06/sets/72157634680501885/ for the latest UX nightly (da2be617863d).

I think we can call this resolved based on this attached screenshot (ux-da2be617863d_22_normal_allToolbars_customizing_noLWT) assuming that this is what the bug was about.