885087 - Generated file mobile/android/base/braille/com/googlecode/eyesfree/braille/selfbraille/ISelfBrailleService.java left in $(SRCDIR)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

The committed patch for Bug 876475 includes the following files:

ISelfBrailleService.aidl
WriteData.aidl
WriteData.java

$(AIDL) generates ISelfBrailleService.java (and presumably WriteData.java).  We should not be checking generated .java files into the tree; we should not even be generating them into $(SRCDIR); and if we absolutely must, we should be listing them in /.hgignore.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

The file generated in $(SRCDIR) was checked into the tree in bug 885298. (I agree it's not ideal but it was the least bad solution).

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #1)
> The file generated in $(SRCDIR) was checked into the tree in bug 885298. (I
> agree it's not ideal but it was the least bad solution).

kats, I'm aware that this is part of 885298, and I'm not going to re-open immediately, but I am going to ask for an explanation of a) why this is "least bad" for one file and b) why the two generated files are treated differently.

If that's linking to a comment of 885298, so be it.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

The initial landing checked in the three files you listed in comment 0. However, WriteData.aidl was only a support file, needed for ISelfBrailleService.aidl to be successfully processed by the aidl tool. The WriteData.java that was checked in is very different from the .aidl and shouldn't be considered a "generated file". [1]

With bug 885298 in the tree the "generated" ISelfBrailleService.java file is checked in, and no more aidl generation is happening. So at least the two .java files are being treated consistently. As for why this was the least bad solution, it is because the alternatives were either (a) bumping up the min SDK requirement to r21 or (b) disabling warning-as-errors. At least, that's my understanding of the problem from the IRC discussion [2].

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=876475#c24
[2] http://irclog.gr/#show/irc.mozilla.org/mobile/292822