885145 - Add tests for mozinfo

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Anhad Jai Singh (:ffledgling)]

additional tests are required for mozinfo

Comment 1

[Anhad Jai Singh (:ffledgling)]

Attachment: Adds tests for to test handling of invalid json by update* methods

Patch adds tests to test handling of invalid json by the update* methods, and removes the removes redundant imports.

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 765118 [details] [diff] [review]
Adds tests for to test handling of invalid json by update* methods

Review of attachment 765118 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozinfo/tests/test.py
@@ +61,5 @@
> +        handle invalid JSON"""
> +        j = os.path.join(self.tempdir, "mozinfo.json")
> +        with open(j, 'w') as f:
> +            f.write('invalid{"json":')
> +        self.assertRaises(ValueError, mozinfo.find_and_update_from_json, self.tempdir)

I don't know that this is terribly useful as the ValueError is going to get raised in "update()" anyway which we're already testing. Maybe instead we could use mock to assert that find_and_update_from_json calls update exactly once (like second example in http://www.voidspace.org.uk/python/mock/getting-started.html#mock-patching-methods).

That being said, it isn't really hurting anything either so if you want to leave it as is that's fine by me.

Comment 3

[Jeff Hammel]

It might be a decent idea to consult https://bugzilla.mozilla.org/show_bug.cgi?id=881417

Comment 4

[Andrew Halberstadt [:ahal]]

https://github.com/mozilla/mozbase/commit/f18923ffbf5e8063dfc50c821f6060d9150c8ead