885190 - Scheduling and other cleanup

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Comment 1

[Eric Rescorla (:ekr)]

Attachment: Scheduling and other cleanup

Comment 2

[Eric Rescorla (:ekr)]

See WebRTC bug:
https://code.google.com/p/webrtc/issues/detail?id=1956&thanks=1956&ts=1371664660

Comment 3

[Timothy B. Terriberry (:derf)]

Comment on attachment 765187 [details] [diff] [review]
Scheduling and other cleanup

Review of attachment 765187 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the requested comment.

Just curious, what's the other cleanup?

::: media/webrtc/trunk/webrtc/system_wrappers/source/thread_posix.cc
@@ +206,5 @@
>    }
>    int result = pthread_attr_setdetachstate(&attr_, PTHREAD_CREATE_DETACHED);
>    // Set the stack stack size to 1M.
>    result |= pthread_attr_setstacksize(&attr_, 1024 * 1024);
> +#if 0

Please add a comment pointing to either this bug or the webrtc.org issue to say why you're doing this.

Comment 4

[Eric Rescorla (:ekr)]

(In reply to Timothy B. Terriberry (:derf) from comment #3)
> Comment on attachment 765187 [details] [diff] [review]
> Scheduling and other cleanup
> 
> Review of attachment 765187 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with the requested comment.
> 
> Just curious, what's the other cleanup?

It's so clean you can't see it. (the log message is stale).


> ::: media/webrtc/trunk/webrtc/system_wrappers/source/thread_posix.cc
> @@ +206,5 @@
> >    }
> >    int result = pthread_attr_setdetachstate(&attr_, PTHREAD_CREATE_DETACHED);
> >    // Set the stack stack size to 1M.
> >    result |= pthread_attr_setstacksize(&attr_, 1024 * 1024);
> > +#if 0
> 
> Please add a comment pointing to either this bug or the webrtc.org issue to
> say why you're doing this.

Willdo.

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7e6a46bbbbf6