Closed Bug 885190 Opened 8 years ago Closed 8 years ago

Scheduling and other cleanup

Categories

(Core :: WebRTC: Audio/Video, defect)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla24

People

(Reporter: ekr, Assigned: ekr)

Details

Attachments

(1 file)

Scheduling and other cleanup
1.42 KB, patch
derf
: review+
Details | Diff | Splinter Review 
No description provided.
Attachment #765187 - Flags: review?(tterribe)
Comment on attachment 765187 [details] [diff] [review]
Scheduling and other cleanup

Review of attachment 765187 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the requested comment.

Just curious, what's the other cleanup?

::: media/webrtc/trunk/webrtc/system_wrappers/source/thread_posix.cc
@@ +206,5 @@
>    }
>    int result = pthread_attr_setdetachstate(&attr_, PTHREAD_CREATE_DETACHED);
>    // Set the stack stack size to 1M.
>    result |= pthread_attr_setstacksize(&attr_, 1024 * 1024);
> +#if 0

Please add a comment pointing to either this bug or the webrtc.org issue to say why you're doing this.
Attachment #765187 - Flags: review?(tterribe) → review+
(In reply to Timothy B. Terriberry (:derf) from comment #3)
> Comment on attachment 765187 [details] [diff] [review]
> Scheduling and other cleanup
> 
> Review of attachment 765187 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with the requested comment.
> 
> Just curious, what's the other cleanup?

It's so clean you can't see it. (the log message is stale).


> ::: media/webrtc/trunk/webrtc/system_wrappers/source/thread_posix.cc
> @@ +206,5 @@
> >    }
> >    int result = pthread_attr_setdetachstate(&attr_, PTHREAD_CREATE_DETACHED);
> >    // Set the stack stack size to 1M.
> >    result |= pthread_attr_setstacksize(&attr_, 1024 * 1024);
> > +#if 0
> 
> Please add a comment pointing to either this bug or the webrtc.org issue to
> say why you're doing this.

Willdo.
https://hg.mozilla.org/mozilla-central/rev/7e6a46bbbbf6
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.