885234 - [A/V] Video frames doesn't show up while streaming

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P1)

Description

[leo.bugzilla.gecko]

When I first try to play it, there’s no problem.
But if it finish buffering once (progress bar colored at the end of it) at first play, video frame is not show up even though audio is played well.

STR
1. Try to play the contents here http://people.mozilla.org/~sikeda/.
2. Make sure that buffering progress bar is at the end of it.
3. Back and try again.
4. no video frames….

Comment 1

[cajbir (:cajbir)]

Is this in the video app or in the browser?

Comment 2

[Sotaro Ikeda [:sotaro]]

(In reply to Chris Double (:doublec) from comment #1)
> Is this in the video app or in the browser?

I saw it in the browser.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Chris,

This bug is not related to video app. It is handled by video element of browser. It should be a gecko bug.

Comment 4

[Sotaro Ikeda [:sotaro]]

The problem happens by change image format from from GRALLOC_PLANAR_YCBCR to PLANAR_YCBCR during playback and ShadowImageLayerOGL can not handle it correctly.

Comment 5

[Sotaro Ikeda [:sotaro]]

Master gecko already handle this situation. Therefore the problem did not happen in master unagi.

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch for b2g18 - handle image type change during video playback

By applying the patch, the problem is fixed on v1.1 unagi.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 766006 [details] [diff] [review]
patch for b2g18 - handle image type change during video playback

Review of attachment 766006 [details] [diff] [review]:
-----------------------------------------------------------------

Great!

::: gfx/layers/opengl/ImageLayerOGL.cpp
@@ +976,5 @@
>          gl()->MakeCurrent();
>          gl()->fActiveTexture(LOCAL_GL_TEXTURE0);
>          gl()->BindExternalBuffer(mExternalBufferTexture.GetTextureID(), graphicBuffer->getNativeBuffer());
>          mImageVersion = imgVersion;
> +    } else if(!img) {

Space before (

Comment 8

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=895bbb6f9ef0

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 for b2g18 - handle image type change during video playback

Apply the comment. Carry "r+=roc".
The patch is only for b2g18.

Comment 10

[Sotaro Ikeda [:sotaro]]

master does not have this problem.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/1db2099ffc19

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/1db2099ffc19