88527 - javascript strict warnings in irc.js

Status: VERIFIED DUPLICATE of bug 103598

(Other Applications :: ChatZilla, defect)

Description

[Henrik Gemal]

to reproduce:
- just open and close the chatzilla

Warning: redeclaration of var ev
Source File: chrome://chatzilla/content/lib/js/irc.js
Line: 331, Column: 8
Source Code:
    var ev = new CEvent ("network", "info", this.parent, "onInfo");

Warning: reference to undefined property this.primServ
Source File: chrome://chatzilla/content/lib/js/irc.js
Line: 235

Warning: redeclaration of var ev
Source File: chrome://chatzilla/content/lib/js/irc.js
Line: 1194, Column: 12
Source Code:
        var ev = new CEvent ("network", "nick", this.parent, "onNick");

Please add the following line to your prefs.js file, so we could avoid all the 
strict warning fixup...:
user_pref("javascript.options.strict", true);

Comment 1

[Francisco León]

Geez man, you could have opened only 1 bug with the summary "javascript strict
warnings when closing chatzilla"
I'm going to do it for you, feel free to flame me for doing so. It takes the
same steps to reproduce the same, just that they are different files
Changing summary
Should this go into javascript? 

Comment 2

[Francisco León]

*** Bug 88528 has been marked as a duplicate of this bug. ***

Comment 3

[Francisco León]

*** Bug 88529 has been marked as a duplicate of this bug. ***

Comment 4

[Francisco León]

*** Bug 88530 has been marked as a duplicate of this bug. ***

Comment 5

[Francisco León]

What about the workaround method of putting that option in the pref file?
Are you getting any loss of a function in chatzilla because of those errors?

Comment 6

[Henrik Gemal]

it's not a js error just js warning telling the developer that something is 
potentially wrong. All js and xul files should work without any warnings.

Comment 7

[Robert Ginda]

Says who?  I for one think that strict mode is too strict, and many of these
warnings are for things I'm not going to change.

Comment 8

[Henrik Gemal]

then I think you're the only one with that attitude. All other @netscape.com 
people I've heard says that we should get rid of all js strict warnings...

Comment 9

[basic]

Robert, even if I provide patches you wouldn't allow it?

Comment 10

[Robert Ginda]

I'd have to see the patches.

I'm not willing to change all of my if (typeof foo == "undefined") tests for
these warnings, so don't bother changing those.  Valid "declared as var twice",
and "foo  used but not declared" type warnings are OK to fix tho.

Comment 11

[Henrik Gemal]

If you dont think all warnings should be fixed please talk to [e-mail]. 
Either warnings should be fixed or the strict option should be less strict. I 
dont care I just want my Mozilla without strict warnings!

Comment 12

[Robert Ginda]

*** This bug has been marked as a duplicate of 103598 ***

Comment 13

[Henrik Gemal]

Verified dupe