Closed Bug 885361 Opened 7 years ago Closed 7 years ago

Add shell option to hide functions that are unsafe for fuzzers

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: till, Assigned: till)

References

Details

Attachments

(1 file, 1 obsolete file)

Unit testers would like to use shell functions that can potentially be dangerous when used wrongly. Fuzzers want to use function wrongly without formatting their hard drives and destroying the internet. This patch makes cats and dogs live together, harmoniously.
Comment on attachment 765392 [details] [diff] [review]
Add shell option to hide functions that are unsafe for fuzzers

Decoder, this should do what's needed, can you verify?
Attachment #765392 - Flags: feedback?(choller)
Comment on attachment 765392 [details] [diff] [review]
Add shell option to hide functions that are unsafe for fuzzers

Really much appreciated :) This should help avoiding some nasty false positives in LangFuzz.
Attachment #765392 - Flags: feedback?(choller) → feedback+
Moved some more functions into the fuzzing-unsafe block based on decoder's feedback on IRC
Attachment #765405 - Flags: review?(terrence)
Attachment #765392 - Attachment is obsolete: true
Attachment #765392 - Flags: review?(terrence)
Comment on attachment 765405 [details] [diff] [review]
Add shell option to hide functions that are unsafe for fuzzers

Review of attachment 765405 [details] [diff] [review]:
-----------------------------------------------------------------

To be fair |js -e "system('rm -rf /')"| didn't reproduce.

r=me
Attachment #765405 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/0a9314155404
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Duplicate of this bug: 879042
Blocks: 886527
You need to log in before you can comment on or make changes to this bug.