885361 - Add shell option to hide functions that are unsafe for fuzzers

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Till Schneidereit [:till]]

Unit testers would like to use shell functions that can potentially be dangerous when used wrongly. Fuzzers want to use function wrongly without formatting their hard drives and destroying the internet. This patch makes cats and dogs live together, harmoniously.

Comment 1

[Till Schneidereit [:till]]

Attachment: Add shell option to hide functions that are unsafe for fuzzers

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 765392 [details] [diff] [review]
Add shell option to hide functions that are unsafe for fuzzers

Decoder, this should do what's needed, can you verify?

Comment 3

[Christian Holler (:decoder)]

Comment on attachment 765392 [details] [diff] [review]
Add shell option to hide functions that are unsafe for fuzzers

Really much appreciated :) This should help avoiding some nasty false positives in LangFuzz.

Comment 4

[Till Schneidereit [:till]]

Attachment: Add shell option to hide functions that are unsafe for fuzzers

Moved some more functions into the fuzzing-unsafe block based on decoder's feedback on IRC

Comment 5

[Terrence Cole [:terrence]]

Comment on attachment 765405 [details] [diff] [review]
Add shell option to hide functions that are unsafe for fuzzers

Review of attachment 765405 [details] [diff] [review]:
-----------------------------------------------------------------

To be fair |js -e "system('rm -rf /')"| didn't reproduce.

r=me

Comment 6

[Till Schneidereit [:till]]

Thanks for the quick review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a9314155404

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0a9314155404