Soft home button isn't enabled by default on Nexus 4

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mwu, Assigned: alive)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Hmm...something wrong in the CSS rule?
(Reporter)

Comment 2

5 years ago
David Baron suggested "@media not all and (-moz-physical-home-button)"

I tried "@media not (-moz-physical-home-button)" while testing the css patch and that didn't work. David's suggestion did, however.
OK...I had tested it but worked, strange.

I think I also forgot to fire holdhome event.

I will fix bug 885473 as well.
I have one question...if I fixed this, will people using simulator see it default turn on?
I think simulator doesn't have "hardware" button right?
Flags: needinfo?(mwu)
(Reporter)

Comment 5

5 years ago
Yeah, it'll turn on on desktop. The simulator has its own "hardware" button, but that can be removed once we have this one. Alternately, they might want to force it off. Let's see if myk has any concerns here.
Flags: needinfo?(mwu) → needinfo?(myk)
(In reply to Michael Wu [:mwu] from comment #5)
> Yeah, it'll turn on on desktop. The simulator has its own "hardware" button,
> but that can be removed once we have this one

If you mean to replace it with this, I don't think so...
The problem is every app's size would be cut by 5rem if we're using software button.
It's not a big deal on nexus device because it's has high resolution.
But will cause trouble on simulator I think..

In firefox nightly, I could use window.location.protocol to detect and turn off natively I think.
But currently I have no idea if gaia was running on simulator or not..

. Alternately, they might want
> to force it off. Let's see if myk has any concerns here.
Created attachment 765786 [details]
https://github.com/mozilla-b2g/gaia/pull/10525

patch v1:
1. Remove the confusing css style.
2. Add holdhome event on software button.
3. Use correct media query rules.
4. Fix simulator and nightly issues. Default turn the software buttons off on them.
Attachment #765786 - Flags: review?(timdream)
With the patch we don't need to change anything in simulator now.
Flags: needinfo?(myk)
Comment on attachment 765786 [details]
https://github.com/mozilla-b2g/gaia/pull/10525

My nexus 4 is not handy now, :mwu could you test this?
Attachment #765786 - Flags: feedback?(mwu)
(Reporter)

Comment 10

5 years ago
Comment on attachment 765786 [details]
https://github.com/mozilla-b2g/gaia/pull/10525

This definitely works better. The only weird thing now is that dragging from the home button still fires an event.
Attachment #765786 - Flags: feedback?(mwu) → feedback+
(In reply to Michael Wu [:mwu] from comment #10)
> Comment on attachment 765786 [details]
> https://github.com/mozilla-b2g/gaia/pull/10525
> 
> This definitely works better. The only weird thing now is that dragging from
> the home button still fires an event.

Does that really matter? I see the same thing on Firefox Nightly. IMO the only weird thing is that we cannot get UX love on the button...

BTW I change the pull request a bit for something is still wrong on desktop. Would you mind trying again on real device? And it's not able to turn off software button on the device really without hardware button now so the settings should be removed..
Attachment #765786 - Flags: review?(timdream) → review+
(Reporter)

Comment 12

5 years ago
(In reply to Alive Kuo [:alive] from comment #11)
> Does that really matter? I see the same thing on Firefox Nightly. IMO the
> only weird thing is that we cannot get UX love on the button...
> 

Don't know if it matters. This is a lot better than the bugs before so I'll take this trade.

> BTW I change the pull request a bit for something is still wrong on desktop.
> Would you mind trying again on real device? And it's not able to turn off
> software button on the device really without hardware button now so the
> settings should be removed..

Still seems to work ok here.
(In reply to Michael Wu [:mwu] from comment #12)
> (In reply to Alive Kuo [:alive] from comment #11)
> > Does that really matter? I see the same thing on Firefox Nightly. IMO the
> > only weird thing is that we cannot get UX love on the button...
> > 
> 
> Don't know if it matters. This is a lot better than the bugs before so I'll
> take this trade.
> 
> > BTW I change the pull request a bit for something is still wrong on desktop.
> > Would you mind trying again on real device? And it's not able to turn off
> > software button on the device really without hardware button now so the
> > settings should be removed..
> 
> Still seems to work ok here.
Thanks, merging.
Assignee: nobody → alive
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Depends on: 905956
Depends on: 905957
You need to log in before you can comment on or make changes to this bug.