885541 - Work - Move devtools icons in app bar into hamburger menu

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: App Bar, defect)

Description

[Jonathan Wilde [:jwilde]]

There's two devtools icons that are in the appbar right now. We don't support tooltips right now, so it's really confusing as to what they do right now. It'd be better if we could have them in the pop-out menu for the hamburger icon with a textual description.

Also, this allows us to punt and avoid having to make shorlander make more icons for the two devtools. They're not consumer facing, and he's busy. :)

Poked Yuan about this and she thinks it makes sense.

Comment 1

[Jonathan Wilde [:jwilde]]

Attachment: patch v1

Comment 2

[Jonathan Wilde [:jwilde]]

Attachment: patch v1.1

Comment 3

[Frank Yan (:fryn)]

Comment on attachment 765698 [details] [diff] [review]
patch v1.1

Review of attachment 765698 [details] [diff] [review]:
-----------------------------------------------------------------

:D

::: browser/metro/base/content/ContextCommands.js
@@ +229,4 @@
>    },
>  
>    // App bar
> +  

Nit: blank line.

::: browser/metro/base/content/appbar.js
@@ +109,5 @@
>  
>    onMenuButton: function(aEvent) {
>        var typesArray = ["find-in-page"];
> +
> +      if (ConsolePanelView.enabled) typesArray.push("ppen-error-console");

s/ppen/open/

Comment 4

[Jonathan Wilde [:jwilde]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03a709825eff

Comment 5

[Ed Morley [:emorley]]

Backed out for metro-chrome failures:
https://tbpl.mozilla.org/php/getParsedLog.php?id=24420314&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/0dd5a67fd870

Comment 6

[Jonathan Wilde [:jwilde]]

Attachment: patch v1.3

Fixes broken tests and broken contextualactions icons.

Comment 7

[Frank Yan (:fryn)]

Let's confirm that the tests no longer fail before pushing.

Comment 8

[Jonathan Wilde [:jwilde]]

Passed try:
https://tbpl.mozilla.org/?tree=Try&rev=5ffde000480d

Still having issues building locally, though.

Comment 9

[Jonathan Wilde [:jwilde]]

Got tests working locally.

Today is the day for the hamburger patch to (finally) land:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf5b7971c179

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cf5b7971c179