Closed Bug 885674 Opened 8 years ago Closed 8 years ago

Alarm API - Delete Alarm API data on app uninstallation (and clear data?) (follow-up)

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: airpingu, Assigned: airpingu)

References

Details

(Whiteboard: [fixed-in-birch])

Attachments

(1 file)

Just a nice to have. We need to add some safer checks to prevent "webapps-clear-data" of an app from clearing all the alarms saved in the DB. It's a bit dangerous.
Attached patch PatchSplinter Review
Although we don't really have a bug for this, I hope to add more checks because the AlarmDB.getAll(...) will get all the alarms saved in the DB if the |manifestURL| is null. That would further remove all the alarms, which sounds really dangerous.
Attachment #765859 - Flags: review?(nsm.nikhil)
Comment on attachment 765859 [details] [diff] [review]
Patch

Review of attachment 765859 [details] [diff] [review]:
-----------------------------------------------------------------

It should be r=nsm :)
Attachment #765859 - Flags: review?(nsm.nikhil) → review+
https://hg.mozilla.org/mozilla-central/rev/07ce3bc9b4dd
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.