Closed
Bug 885676
Opened 11 years ago
Closed 11 years ago
Unit test for screen manager and wake lock
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alive, Assigned: yurenju)
References
Details
(Keywords: regression, reproducible)
Attachments
(1 file)
To avoid regression like bug 880931 happens again,
we need some kind of unit test for screen manager, especially about wake lock.
|
Assignee | |
Updated•11 years ago
|
Assignee: alive → yurenju.mozilla
|
|
Assignee | |
Comment 2•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 768865 [details]
Testing for ScreenManager: https://github.com/mozilla-b2g/gaia/pull/10694
><!DOCTYPE html><meta charset="utf-8"><meta http-equiv="refresh" content="5;https://github.com/mozilla-b2g/gaia/pull/10694"><title>Bugzilla Code Review</title><p>You can review this patch at <a href="https://github.com/mozilla-b2g/gaia/pull/10694">https://github.com/mozilla-b2g/gaia/pull/10694</a>, or wait 5 seconds to be redirected there automatically.</p>
Attachment #768865 -
Attachment description: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10694 → Part 1: Testing for ScreenManager.init() https://github.com/mozilla-b2g/gaia/pull/10694
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 768865 [details]
Testing for ScreenManager: https://github.com/mozilla-b2g/gaia/pull/10694
ready for review :D
Attachment #768865 -
Attachment description: Part 1: Testing for ScreenManager.init() https://github.com/mozilla-b2g/gaia/pull/10694 → Testing for ScreenManager: https://github.com/mozilla-b2g/gaia/pull/10694
Attachment #768865 -
Flags: review?(alive)
|
Reporter | |
Comment 5•11 years ago
|
||
Comment on attachment 768865 [details]
Testing for ScreenManager: https://github.com/mozilla-b2g/gaia/pull/10694
My suggestion is separate the test cases even you're testing the same function with different arguments.
Attachment #768865 -
Flags: review?(alive) → review+
|
|
Reporter | |
Comment 6•11 years ago
|
||
Thanks for the effort bringing sinon!
|
|
Assignee | |
Comment 7•11 years ago
|
||
Seprated test cases from same functions with different arguments! :D
|
|
Assignee | |
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•