885729 - Inline array and proxy specializations of js::DefineProperty into js::DefineProperties

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Till Schneidereit [:till]]

I'm not sure how, but I stumbled upon this and think that we could do well with hoisting all those checks from js::DefineProperty into js::DefineProperties.

To make that work, I had to remove the duplication of DefineProperties from Object.cpp and expose the declaration in jsobj.h. Shout if I should do something different.

I don't actually know which benchmarks test our performance here, if any, so I don't know if it'll be a visible win somewhere. I would wager that it will speed up some real code, somewhere, however.

Comment 1

[Till Schneidereit [:till]]

Attachment: v1

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 765910 [details] [diff] [review]
v1

Review of attachment 765910 [details] [diff] [review]:
-----------------------------------------------------------------

Probably not much code uses Object.defineProperties yet, but yeah, this'll speed up whatever exists, or will exist at some point.

Comment 3

[Till Schneidereit [:till]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/612c36049571

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/612c36049571