885766 - Saner testing API for JS options

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

What we have:

        var hadWerror = options().split(",").indexOf("werror") !== -1;

        // Ensure the "werror" option is disabled.
        if (hadWerror)
            options("werror");

        try {
            ...
        } catch (exc) {
            if (hadWerror)
                options("werror");
            throw exc;
        }

        // Enable the "werror" option.
        options("werror");

        try {
            ...
        } finally {
            if (!hadWerror)
                options("werror");
        }

What we want:

    var hadWerror = options.werror;
    try {
        options.werror = true;
        ...
        options.werror = false;
        ...
    } finally {
        options.werror = hadWerror;
    }

Or maybe:

    withOptions({werror: true}, () => {
        ...;
    });

    withOptions({werror: false}, () => {
        ...;
    });