885787 - self-serve agent shouldn't follow redirects after stopping builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

Attachment: use noredirect opener for stopping builds

To stop a build, the self serve agent does an HTTP GET request to the build's stop url. e.g.

http://dev-master01.build.mozilla.org:8049/builders/b2g_mozilla-central_ics_armv7a_gecko%20build/builds/13/stop

buildbot responds with a 302 response, redirecting to the builder/ page. The default urllib implementation follows that redirect, and so has to request the builder page, which increases load on the build masters.

This patch creates a "noredirect_opener" url opener, which doesn't follow HTTP 302 responses.

Comment 1

[John Hopkins (:jhopkins)]

Comment on attachment 765959 [details] [diff] [review]
use noredirect opener for stopping builds

Looks good!  Tested mechanism separately and it works as expected.

Comment 2

[Chris AtLee [:catlee]]

working as expected