Closed Bug 885819 Opened 7 years ago Closed 7 years ago

Navigator.cpp build failure with --disable-media-navigator --enable-gamepad

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: mark.yen, Assigned: mark.yen)

Details

Attachments

(1 file)

--enable-gamepad causes Navigator.cpp to want to use nsGlobalWindow, which is normally included via MediaManager.h when --enable-media-navigator (which is the default in firefox/b2g/thunderbird/etc., but *not* in configure.in).

Attached patch should fix things; try run at https://tbpl.mozilla.org/?tree=Try&rev=8b8d70a25ab9
Attachment #766000 - Flags: review?(bugs)
Comment on attachment 766000 [details] [diff] [review]
#include nsGlobalWindow.h

perhaps just unconditionally include nsGlobalWindow
Attachment #766000 - Flags: review?(bugs) → review+
(Changed to an unconditional include)
https://hg.mozilla.org/integration/mozilla-inbound/rev/92076b9e6edd

I think I missed the 24 train...
https://hg.mozilla.org/mozilla-central/rev/92076b9e6edd
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.