If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Navigator.cpp build failure with --disable-media-navigator --enable-gamepad

RESOLVED FIXED in mozilla25

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Mook (work), Assigned: Mook (work))

Tracking

Trunk
mozilla25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 766000 [details] [diff] [review]
#include nsGlobalWindow.h

--enable-gamepad causes Navigator.cpp to want to use nsGlobalWindow, which is normally included via MediaManager.h when --enable-media-navigator (which is the default in firefox/b2g/thunderbird/etc., but *not* in configure.in).

Attached patch should fix things; try run at https://tbpl.mozilla.org/?tree=Try&rev=8b8d70a25ab9
Attachment #766000 - Flags: review?(bugs)

Comment 1

4 years ago
Comment on attachment 766000 [details] [diff] [review]
#include nsGlobalWindow.h

perhaps just unconditionally include nsGlobalWindow
Attachment #766000 - Flags: review?(bugs) → review+
(Assignee)

Comment 2

4 years ago
(Changed to an unconditional include)
https://hg.mozilla.org/integration/mozilla-inbound/rev/92076b9e6edd

I think I missed the 24 train...
https://hg.mozilla.org/mozilla-central/rev/92076b9e6edd
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.