Status

Release Engineering
General
RESOLVED FIXED
5 years ago
19 days ago

People

(Reporter: Margaret, Assigned: aki)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
The mobile team has been working on an about:home rewrite on fig, and we'd like nightly builds for people to test.

I'm not sure what the process is here - can we get updates, similarly to how the UX branch works?
found in triage. moving to correct component.

Yes, should be possible, all branches have basically the same mechanics behind the scenes, but I'll let someone who knows that code better comment. 

What OS do you want nightlies for?
Component: Release Engineering → Release Engineering: Automation (General)
QA Contact: catlee
(Reporter)

Comment 2

5 years ago
(In reply to John O'Duinn [:joduinn] from comment #1)

> What OS do you want nightlies for?

Just Android. Thanks!
(Reporter)

Comment 3

5 years ago
Is there any more information I should provide here? We'd like to get these builds going :) Thanks!
(Assignee)

Comment 4

5 years ago
Created attachment 767872 [details] [diff] [review]
fig android nightlies
Attachment #767872 - Flags: review?(bhearsum)
Comment on attachment 767872 [details] [diff] [review]
fig android nightlies

Review of attachment 767872 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla/project_branches.py
@@ +338,4 @@
>              'android-debug': {},
>              'android-noion': {},
>              'android-armv6': {},
>              'android-x86': {},

You may need to set the flags to False here. I'm not sure what they default to...
Attachment #767872 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 6

5 years ago
Comment on attachment 767872 [details] [diff] [review]
fig android nightlies

Sure.

https://hg.mozilla.org/build/buildbot-configs/rev/656793d2161d

Should take effect the next reconfig (tomorrow?)
Attachment #767872 - Flags: checked-in+
(Reporter)

Comment 7

5 years ago
Thanks for the quick response! :)

Comment 8

5 years ago
In production
(Assignee)

Comment 9

5 years ago
Kicked off a fig nightly via https://secure.pub.build.mozilla.org/buildapi/self-serve/fig (on revision c150a39332d6)
Assignee: nobody → aki
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Don't you still have to touch CVS in http://mxr.mozilla.org/mozilla/source/webtools/aus/xml/inc/config-dist.php#267 and friends to make updates work? That horror was why I was avoiding this bug.
(Assignee)

Comment 11

5 years ago
Hm, good catch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 12

5 years ago
Created attachment 768061 [details] [diff] [review]
aus fig
Attachment #768061 - Flags: review?(nthomas)
Attachment #768061 - Flags: review?(nthomas) → review+
(Assignee)

Comment 13

5 years ago
Comment on attachment 768061 [details] [diff] [review]
aus fig

Checking in config-dist.php;
/cvsroot/mozilla/webtools/aus/xml/inc/config-dist.php,v  <--  config-dist.php
new revision: 1.261; previous revision: 1.260
done
(bb08)deathduck:/src/fig/aus/xml/inc [16:41:32]
1215$ cvs tag -F -r 1.261 AUS2_PRODUCTION config-dist.php
T config-dist.php
Attachment #768061 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Depends on: 887571
Comment on attachment 768061 [details] [diff] [review]
aus fig

Review of attachment 768061 [details] [diff] [review]:
-----------------------------------------------------------------

Had to push a bustage fix:

Checking in xml/inc/config-dist.php;
/cvsroot/mozilla/webtools/aus/xml/inc/config-dist.php,v  <--  config-dist.php
new revision: 1.262; previous revision: 1.261
done
$ cvs tag -F -r 1.262 AUS2_PRODUCTION xml/inc/config-dist.php
RSA host key for IP address '63.245.215.43' not in list of known hosts.
T xml/inc/config-dist.php

... (issue below)

::: config-dist.php
@@ +329,5 @@
>             'nightly-birch'           => 'mozilla-central',
>             'nightly-ash'             => 'ash',
>             'nightly-maple'           => 'maple',
>             'nightly-oak'             => 'oak'
> +           'nightly-fig'             => 'fig',

no comma on "oak" here, and because other arrays here did not have a trailing comma, and I didn't want to lookup php syntax to remember if thats still legal, I dropped the trailing comma on 'fig',
Apologies for the review failure here. FTR, a trailing comma is fine, and best practice is to run 'php -l <file>' on any file after modifying. Also reviewing with your eyes open.
(Assignee)

Comment 16

5 years ago
(In reply to Nick Thomas [:nthomas] from comment #15)
> Apologies for the review failure here. FTR, a trailing comma is fine, and
> best practice is to run 'php -l <file>' on any file after modifying. Also
> reviewing with your eyes open.

Also writing patches with your eyes open =\
Thanks for the fix+followup bugs.

http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-fig-android/

I think we're done here.
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.