Closed Bug 885925 Opened 11 years ago Closed 11 years ago

Header in the calendar sidebar is different from the header in the building block

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: nhirata, Assigned: pivanov)

Details

(Whiteboard: visual design, visual-tracking)

Attachments

(3 files)

screenshot
142.37 KB, image/png
Details
After patch
113.88 KB, image/png
epang
: feedback+
Details
patch for Gaia repo
183 bytes, text/html
sjochimek
: review+
Details
Attached image screenshot — 
"mozilla-central" path="gecko" revision="7ba8c86f1a56"
"gecko.git" revision="044c968435ee8c809e6e29b0815393d17959bd83"
"gaia.git" revision="e2f19420fa6a26c4287588701efaec09a750dba1"
Build : 2013-06-21-03-12-31

1. launch Calendar
2. setup an account on Calendar
3. open the side bar
4. hit home
5. launch settings
6. compare the headers

Expected: they match
Actual: they do not match

Follow up to bug 844575
Pavel, can you fix this? Thanks!
Assignee: nobody → pivanov
Whiteboard: visual design, visual-tracking
Attached image After patch — 

        Attachment #766744 -
        Flags: feedback?(epang)

    
    

    
  
Comment on attachment 766744 [details]
After patch

Looks good, thanks Pavel!

        Attachment #766744 -
        Flags: feedback?(epang) → feedback+

        Attachment #766745 -
        Flags: review?(sjochimek)

    
    

    
  
Comment on attachment 766745 [details]
patch for Gaia repo

Pavel: Nice one ;-)

Landed in master: https://github.com/mozilla-b2g/gaia/commit/f62f3de9eda772c14ead4cafc50b171885ab162d

        Attachment #766745 -
        Flags: review?(sjochimek) → review+

    
    

    
  
Hi Naoki, this is fixed and ready for verification!
Flags: needinfo?(nhirata.bugzilla)

    
    

    
  
Verified:
gecko : 47c6136bd44cd169e02ab14cfde3137bcbf3777a
gaia : 59c7f4a59157a0bc1c45d705294395f988c509b2
build id : 2013-06-28-03-13-23
Mozilla-central
Unagi
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(nhirata.bugzilla)
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: