Closed Bug 886014 Opened 11 years ago Closed 11 years ago

java.lang.StringIndexOutOfBoundsException at java.lang.String.startEndAndLength(String.java) at org.mozilla.gecko.VideoPlayer.onCreate(VideoPlayer.java)

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
critical

Tracking

(firefox22 wontfix, firefox23 wontfix, firefox24 wontfix, firefox25 wontfix, firefox26 fixed, firefox27 fixed, firefox28 fixed, b2g-v1.2 fixed)

RESOLVED FIXED
Firefox 28
Tracking Status
firefox22 --- wontfix
firefox23 --- wontfix
firefox24 --- wontfix
firefox25 --- wontfix
firefox26 --- fixed
firefox27 --- fixed
firefox28 --- fixed
b2g-v1.2 --- fixed

People

(Reporter: scoobidiver, Assigned: rnewman)

Details

(Keywords: crash, Whiteboard: [native-crash])

Crash Data

Attachments

(1 file)

There are a few crashes in 22.0 Beta, 23.0a2 and 24.0a1.

Here is a crash report: bp-e0ef9bdd-f8f5-4909-83b9-fbebb2130619.

java.lang.StringIndexOutOfBoundsException: length=11; regionStart=0; regionLength=-1
	at java.lang.String.startEndAndLength(String.java:583)
	at java.lang.String.substring(String.java:1464)
	at org.mozilla.gecko.VideoPlayer.onCreate(VideoPlayer.java:41)
	at android.app.Activity.performCreate(Activity.java:5110)
	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1080)
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2261)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2357)
	at android.app.ActivityThread.access$600(ActivityThread.java:153)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1247)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:5231)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:795)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:562)
	at dalvik.system.NativeStart.main(Native Method)

A comment says: "I tried to play a embedded youtube video. My user agent was "IPad"."

More reports at:
https://crash-stats.mozilla.com/query/query?product=FennecAndroid&query_search=signature&query_type=contains&query=java.lang.String.startEndAndLength&do_query=1
The code assumes that all YouTube videos have params.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Attachment #827214 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/integration/fx-team/rev/f6a8fcd4a447

mfinkle, do we want to uplift this? There are 26 crashes in the last week going all the way back to 24.
Hardware: ARM → All
Whiteboard: [native-crash] → [native-crash][fixed in fx-team]
Target Milestone: --- → Firefox 28
(In reply to Richard Newman [:rnewman] from comment #3)
> https://hg.mozilla.org/integration/fx-team/rev/f6a8fcd4a447
> 
> mfinkle, do we want to uplift this? There are 26 crashes in the last week
> going all the way back to 24.

Sure. It's low risk and not in our primary distribution. If it reduces crashes. I'm fine with it.
Comment on attachment 827214 [details] [diff] [review]
Don't assume that all vnd.youtube URLs have params. v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  Long ago.

User impact if declined: 
  Some devices/distributions will crash when trying to play a YouTube video.

Testing completed (on m-c, etc.): 
  Just started baking. Not thoroughly tested (it's a fallback path), but I'll do so by the end of the week (before I uplift!).

Risk to taking this patch (and alternatives if risky): 
  Very, very low. Just does an out-of-range check.

String or IDL/UUID changes made by this patch:
  None.
Attachment #827214 - Flags: approval-mozilla-beta?
Attachment #827214 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/f6a8fcd4a447
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [native-crash][fixed in fx-team] → [native-crash]
Attachment #827214 - Flags: approval-mozilla-beta?
Attachment #827214 - Flags: approval-mozilla-beta+
Attachment #827214 - Flags: approval-mozilla-aurora?
Attachment #827214 - Flags: approval-mozilla-aurora+
I'm unable to reproduce the original crash on an early beta, which I think means that I haven't found a suitable video. Unless someone can find one, we'll have to just watch the numbers.
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: