886018 - #error in stl_wrappers causing new gtkEmbed build difficulties

Status: RESOLVED INVALID

(Core :: General, defect)

Description

[Steve Williams]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release)
Build ID: 20130512193848

Steps to reproduce:

compiled new gtkEmbed, here against moz-central :

https://bugzilla.mozilla.org/show_bug.cgi?id=885785


Actual results:

# error "STL code can only be used with infallible ::operator new()"

hit in various  [moz_build]/dist/stl_wrappers headers.


Expected results:

those #error lines should not be hit by XPCOM_GLUE gated code.

XPCOM_GLUE means we are an external embedding app. moz headers should not restrict external app stl use or if they must, a very clear explanation of the restriction and why it's required should be stated. I don't understand that error.

Suggest replacing :

#if !defined(XPCOM_GLUE) && !defined(NS_NO_XPCOM) && !defined(MOZ_NO_MOZALLOC)

with 

#if !defined(MOZ_NO_MOZALLOC)

in those headers.

Comment 1

[Steve Williams]

alternatively, happy to modify new gtkEmbed code to meet restrictions once I understand if that's necessary.