886036 - Port pseudoclass lock to the inspector actor

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Dave Camp (:dcamp)]

Attachment: WIP 1

Comment 1

[Dave Camp (:dcamp)]

Attachment: v1

Comment 2

[Heather Arthur [:harth]]

Comment on attachment 767381 [details] [diff] [review]
v1

Review of attachment 767381 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/inspector/selection.js
@@ +93,5 @@
>  
>      if (attributeChange)
>        this.emit("attribute-changed");
> +    if (pseudoChange)
> +      this.emit("pseudoclass");

If you add any more mutations here, you might want to consider a hash or something:

let changes = {};
for (let m of mutations) {
  changes[m.type] = true;
}

for (let type in changes) {
  this.emit(type);
}

I guess the detached case is a little more complicated. Looks alright right now.

Comment 3

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/eb6cf1052d77

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/eb6cf1052d77