Intermittent browser_newtab_bug723121.js | grid is now locked - Got false, expected true
RESOLVED
FIXED
in Firefox 24
Status
()
People
(Reporter: philor, Assigned: ttaubert)
Tracking
({intermittent-failure})
Firefox Tracking Flags
(firefox24 fixed, firefox25 fixed)
Details
Attachments
(1 attachment)
|
1.05 KB,
patch
|
smaug
:
review+
bajaj
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/php/getParsedLog.php?id=24463580&tree=Mozilla-Central Windows XP 32-bit mozilla-central pgo test mochitest-browser-chrome on 2013-06-22 03:24:06 PDT for push cea75ce9a559 slave: t-xp32-ix-023 03:27:24 INFO - TEST-START | chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_bug723121.js 03:27:24 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_bug723121.js | grid is unlocked 03:27:24 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_bug723121.js | grid is now locked - Got false, expected true 03:27:24 INFO - Stack trace: 03:27:24 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536 03:27:24 INFO - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_bug723121.js :: checkGridLocked :: line 29 03:27:24 INFO - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_bug723121.js :: runTests :: line 16 03:27:24 INFO - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/newtab/head.js :: <TOP_LEVEL> :: line 54 03:27:24 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: testScope/test_executeSoon/<.run :: line 565 03:27:24 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 03:27:24 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_bug723121.js | grid isn't locked anymore
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
|
||
Comment 49•5 years ago
|
||
Hi Tim, can you please find an owner for this? It is a very frequent and recent regression.
Flags: needinfo?(ttaubert)
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
|
||
Updated•5 years ago
|
||
Assignee: nobody → ttaubert
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
|
(Assignee) | |
Comment 65•5 years ago
|
||
Good news is that I can reproduce it locally with enough test runs. Bad news is I have no clue what happens here, yet. I'm working on it.
Flags: needinfo?(ttaubert)
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
|
|
(Assignee) | |
Updated•5 years ago
|
||
OS: Windows XP → All
Hardware: x86 → All
|
|
(Assignee) | |
Updated•5 years ago
|
||
Status: NEW → ASSIGNED
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
|
|
(Assignee) | |
Comment 75•5 years ago
|
||
Turns out the dragstart event is not dispatched due to the frame tree not being up-to-date when calling nsIDOMWindowUtils.dispatchDOMEventViaPresShell().
|
|
(Assignee) | |
Comment 76•5 years ago
|
||
Created attachment 771101 [details] [diff] [review] make sure frame tree is up-to-date before nsIDOMWindowUtils dispatches events via PresShell The test was failing intermittently since newtab preloading was enabled. DocShell swapping (used by newtab preloading) happens synchronously and we should be able to dispatch events right after that happened. Sometimes, the frame tree might not be up-to-date though because pending layout changes have not been processed, yet. nsIDOMWindowUtils.dispatchDOMEventViaPresShell() should therefore flush the layout before dispatching the event. The method is only used by tests.
Attachment #771101 -
Flags: review?(bugs)
|
|
(Assignee) | |
Updated•5 years ago
|
||
Attachment #771101 -
Attachment description: make sure frame tree is up-to-date before dispatching events via PresShell → make sure frame tree is up-to-date before nsIDOMWindowUtils dispatches events via PresShell
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
|
||
Updated•5 years ago
|
||
Attachment #771101 -
Flags: review?(bugs) → review+
|
|
(Assignee) | |
Comment 80•5 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/4f0f68d919ba
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
|
|
(Assignee) | |
Comment 86•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4f0f68d919ba
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
|
|
||
Comment 97•5 years ago
|
||
Tim, can you please request beta uplift approval on this? Thanks :)
status-firefox24: --- → affected
status-firefox25: --- → fixed
|
|
||
Updated•5 years ago
|
||
Flags: needinfo?(ttaubert)
|
|
(Assignee) | |
Comment 98•5 years ago
|
||
Comment on attachment 771101 [details] [diff] [review] make sure frame tree is up-to-date before nsIDOMWindowUtils dispatches events via PresShell [Approval Request Comment] Bug caused by (feature/regressing bug #): ??? User impact if declined: None. Testing completed (on m-c, etc.): Works great since Firefox 25. Risk to taking this patch (and alternatives if risky): Virtually no risk. Affects test suites, only. No risk if used outside because it only flushes pending layout changes. String or IDL/UUID changes made by this patch: None. This doesn't have any user-facing impact as we don't use nsIDOMWindowUtils.dispatchDOMEventViaPresShell() outside of test suites. The main intention here is to decrease the number of intermittent oranges on ESR.
Attachment #771101 -
Flags: approval-mozilla-beta?
|
||
Updated•5 years ago
|
||
Attachment #771101 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Comment 99•5 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/e813a6df4950
status-firefox24: affected → fixed
Flags: needinfo?(ttaubert)
You need to log in
before you can comment on or make changes to this bug.
Description
•