Closed Bug 886150 Opened 12 years ago Closed 12 years ago

/teach Makes shouldn't have to be recommended on front page on order to go on /teach

Categories

(Webmaker Graveyard :: webmaker.org, defect)

Product:
Webmaker Graveyard
Component:
webmaker.org
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Jacob, Assigned: daleee)

References

Details

(Whiteboard: [mentor] [aug1] s=20130729 p=1)

Attachments

(1 file)

https://github.com/mozilla/webmaker.org/pull/327
48 bytes, text/x-github-pull-request
kate
: review+
Details | Review
Right now if you want a Make to be on the /teach page, it has to be tagged webmaker:recommended which forces it on the webmaker.org front page as well. We need a solution so this is not required in order to keep the home page relevant for young makers rather than older mentors.
Assignee: nobody → dale
Assignee: dale → kate
Assignee: kate → dale
Hey Kat, So for this change to happen, we'll have to change the tags that a make has in order for it to appear on the /teach page and not the home page. Right now, the following tags are applied to /teach makes: - webmaker:recommended - guide The front page displays all makes tagged: - webmaker:recommended So we need to change /teach makes from having webmaker:recommended to something unique to teaching kits.. perhaps webmaker:teach-recommended or something? We should coordinate on this though so both changes happen at the same time & the proper content is shown on /teach.
Flags: needinfo?(kat)
Hi Dale - speaking to Laura now, who is the best person to ask about keywords in this instance since she'll be managing /teach. Have pinged her so she should be able to jump in and get involved now :) And do let me know what you decide so I can keep track from the frontpage perspective!
Flags: needinfo?(kat) → needinfo?(laura)
I'd be fine with webmaker:teach-recommended Better than trying to come up with completely new tagging structures for the /teach page, and it's easy to remember. Will there be a teach-featured too? Recommended, as I understand, is Mozilla made, featured is for partner/community made – right? We'll need both in /teach.
Flags: needinfo?(laura)
This sounds good. And yes Laura, that's also the understanding I have regarding the difference between "Recommended" and "featured". I'm going to cc Matt on this, because as I understood from him following our meeting last week, the desire was to remove the "filter" functionality for the time being until we had a better idea of what those filters would be. If we remove it entirely, you won't be able to have both featured and recommended as there's no way to switch between the two. If you'd like to keep the "featured" filter, we could remove the other ones (popcorn and thimble, which as I understand it are not currently doing anything), but then Featured would be your only filter (which I think would be weird). Perhaps a better solution for the time being – unless we can sort out the other filter labels asap – is that in terms of content strategy, you can group the recommended and featured content together for /teach, keeping the tag as "webmaker:teach-recommended". Make sense? Let us know what solution would be most handy for you guys.
+1 remove the filter completely for now. We can tag everything teach-recommended and circle back to distinguishing between Mozilla made and partner/community made later.
Sounds good! Dale, in case this wasn't clear, we are keeping "filter" on the homepage, and removing it from "/teach". Filed the latter in bug 890906.
* This all sounds good to me. One question though for my own understanding: * I thought the difference between "featured" and "recommended" for teaching kits went like this: ** "featured" = appears on webmaker.org front page ** "recommended" = appears in the main gallery on /teach. But not on front page of webmaker.orgh * Is that correct?
* One other note on how we think about "featured" and "recommended" * I'd suggest avoiding distinction between "Mozilla-made" vs. "other-made" in this regard. * "recommended" should just = "teaching guides we think are really good." And that we therefore want to display more prominently." Whether they're made by Mozilla, community, or partners. * We can use the author meta-data, design elements and branding to indicate who the makes are from. But I don't think that needs to figure into how we "recommend." * The main goal of "recommended" is: an easy way to single out the very best teaching kits. So we can get them front and center in front of users more prominently. * Sound right?
Sounds right to me. Another way of thinking about it is also tied to its functionality: ** Recommended = landing page (either homepage or /teach), what the user sees when they first land on the site/section. Whatever the strategy is for that page. I know Kat is working on a fuller content strategy for the homepage, we should all chat once she's ready and/or this is more established. ** Featured = content that must be displayed for some reason or another, eg. from Partners. This may or may not replicate makes from the "recommended" tag. And you may need to experiment with how you actually use this tag. The main functional need we're meeting with this is to differentiate between landing page content and the makes you'd like to (or need to) promote, in case those are actually separate. You're right to say Mozilla-made is not the issue – that is a separate one, a branding/identity question for the site as a whole. Which is why we should all collaborate when it comes to landing-page content strategy, design elements, etc.
@ Cassie: is this blocked on shipping the new teaching kit template?
@Matt - no. Dale, updates on this?
Flags: needinfo?(dale)
* Ok thanks Cassie. Dale, any context or updates appreciated, just so we have a better sense of how to curate the /teach page and add new teaching kits there as we go
Hey, apologies for taking a while to get back to you all on this! I can change over the tag used for the /teach landing page from "webmaker:recommended" to "webmaker:teach-recommended" whenever. All current makes in the API that you want to appear when landing on /teach will have to happen at the same time for the transition to appear smoothly on the live site, I'd imagine. So the default landing tags would be "webmaker:teach-recommended" and "guide".
Flags: needinfo?(dale)
>>All current makes in the API that you want to appear when landing on /teach will have to happen at the same time Sorry, I don't understand this. Are you saying we need to go into the MakeAPI editor and switch the tags for all /teach featured makes at the same time?
(In reply to Dale Karp (:daleee) from comment #13) > All current makes in the API that you want to appear when landing on /teach will have to happen at the same time for the transition to appear smoothly on the live site, I'd imagine. * I just spoke to Laura and I think we understand on what you're saying here now. > So the default landing tags would be "webmaker:teach-recommended" and "guide". QUESTION: could we treat this as an opportunity to update and simplify this nomenclature a little? @ Cassie: as per our conversation yesterday, what do you think of this proposal: * 1) Use the meta-tag "teach." Makes that we want to appear in the /teach section of the site could just be meta-tagged with "teach." (Instead of the current "guide," which is potentially confusing.) * 2) RECOMMENDED teach makes could be just be meta-tagged "recommended" * 3) Makes that are tagged both "teach" and "recommended" should appear in the recommended section of /teach. Does that make sense?
Hey guys, I had a comment that got lost in netherland.... but Matt, I believe we're mostly on the same page. I wanted to reply to a couple things from Dale: (In reply to Dale Karp (:daleee) from comment #13) > I can change over the tag used for the /teach landing page from > "webmaker:recommended" to "webmaker:teach-recommended" whenever. All current > makes in the API that you want to appear when landing on /teach will have to > happen at the same time for the transition to appear smoothly on the live > site, I'd imagine. The "I'd imagine" makes me nervous - who do we need to ask to find out for sure? I assume you're saying that all the current teach tags will need to be updated with the new tags before you can do this? If so, would be a good idea to file a new bug as a blocker for this and cc Laura. > So the default landing tags would be "webmaker:teach-recommended" and > "guide". As Matt mentions above, "Guide" is not the ideal tag for teaching kits any longer because (a) they're now called "teaching kits" and b) "guide" is ambiguous and could mean "event-guide". I'm okay with "teach" as a tag, but we should double check that "recommend" does not conflict with the current workflow of getting content featured on the homepage. I think Matt's proposal is adding additional logic, so it's probably simpler to just be "teach-recommended". Dale, can you confirm this or find out for us?
Flags: needinfo?(dale)
Two things about Matt's proposal 1) I believe there's a convention where you have to have a webmaker: prefix in a tag in order to give it a functionality on the site, rather than a normal tag that just organizes things by a topic. So would have to be webmaker:teach 2) We want to double check that we have appropriate permissions set in place so the average user can't tag something as "teach" and have it change the website :)
> I assume you're saying that all the current teach tags will need to be > updated with the new tags before you can do this? If so, would be a good > idea to file a new bug as a blocker for this and cc Laura. +1 > it's probably simpler to just be "teach-recommended". + 1
(In reply to Jacob [:Jacob] from comment #17) > webmaker:teach +1 > 2) We want to double check that we have appropriate permissions set in place > so the average user can't tag something as "teach" and have it change the > website +1 -- please let us know the best way to do that. :)
Whiteboard: [mentor]
Whiteboard: [mentor] → [mentor] [aug1]
Nice thinking, Jacob, very important points. Dale, can you let us know what you've found out here and file any appropriate followup bugs? Thanks!
Hi, So any tag prefixed with "webmaker:" is something the user cannot set themselves on a Make they have created. So "webmaker:teach" would work. As for switching over, I say this because as soon as the front-end changes for this patch go live, all teaching kits previously tagged with the old tags ("webmaker:teach-recommended" and "guide") would no longer show on the teach page. Options we have for the above: 1) Do a search for both the old tags ("webmaker:teach-recommended" and "guide") and the new ones decided in this bug. Tag new teaching kits with the new standard, leave the old ones alone. or 2) Parallelize efforts to have the old teaching kits re-tagged right as the new tagging system goes in place. This means when this fix goes live, the current teaching kits will still show on /teach, having the new tags required to be on the front page. So if I understand correctly, the convention we want is: 1) Teaching kits will be tagged webmaker:teach 2) Teaching kits we want to appear on /teach will be tagged webmaker:teach AND webmaker:teach-recommended. We can implement this as soon as we figure out how to handle the makes currently tagged with the "webmaker:teach-recommended" and "guide" convention.
Flags: needinfo?(dale)
@Dale - you're convention is correct! I think we should tag the NEW kits properly and send this patch live once those kits are ready to go. Tags on other /teach content that needs to stay can be modified after the new kits are launched. We'll have to put this on hold for now.
Depends on: 891566, 891546
oh, also on https://webmaker.org/teach all the makes say "Guide make by..." – Will this change along with the updated tags, or do we need to file another bug? Should say "Teach make by..."
Whiteboard: [mentor] [aug1] → [mentor] [aug1] s=20130722 p=1
Hello Laura, So I just wanted to verify the following: The makes with the following tags should appear on teach webmaker:teach AND webmaker:teach-recommended. Do we care that older kits will not be visible on the /teach page until those makes have their tags updated to webmaker:teach AND webmaker:teach-recommended? If not, then the only thing left for me to do is write a patch that updates the default tags that webmaker.org looks for when hitting the /teach page.
Flags: needinfo?(laura)
>The makes with the following tags should appear on teach webmaker:teach AND webmaker:teach-recommended. Verified. That is correct. >Do we care that older kits will not be visible on the /teach page until those makes have their tags updated to webmaker:teach AND webmaker:teach-recommended? We need to schedule this. Otherwise, /teach will be empty. That's bad. I'm waiting on bug 891546 before we can schedule. Hopefully we can swap /teach for new content by Aug 1st.
Flags: needinfo?(laura)
Alright, sounds good! I hope to have bug 891546 done by today so I am feeling quite optimistic about Aug 1st for getting this all sorted out. I shall report back to this bug once bug 891546
(In reply to Dale Karp (:daleee) from comment #26) OMG EXCITED! Maybe tomorrow I can already get things lined up and we can retag this week! Optimism ;)
Whiteboard: [mentor] [aug1] s=20130722 p=1 → [mentor] [aug1] s=20130729 p=1
* What's the status on this one? Hoping to add some new kits to the /teach page using the awesome new template today!
Attachment #790311 - Flags: review?(kate) → review+
Commits pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/7e344218273870dea5f7d747b7a1a091706c2157 [bug 886150] Standardizing /teach tagging rules https://github.com/mozilla/webmaker.org/commit/9ef9443f5082039e6054155e01eaecb22c30f2bd Merge pull request #327 from daleee/886150-teach-tag-fixes [bug 886150] Standardizing /teach tagging rules
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
So tagging rules for teach: * "webmaker:teach" is now the default tag for /teach * You can prioritize certain makes to appear at the top of the list by also tagging it with "webmaker:teach-N", where N is a unique number (Matt, I know I told you you can just tag multiple things like "webmaker-teach-1" but I was wrong; they need to be unique. So if you have 10 makes you want to appear in the first 10 spots, you would tag them as "webmaker:teach-1", "webmaker:teach-2", "webmaker:teach-3", ..., "webmaker:teach-10" I'm pushing this to staging right now to test, will let Matt know once we are nearly ready to push to prod.
Commits pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/e7af8c8c9610ae51a8e93cdda9f5453e70b3dc3e [bug 886150] Standardizing /teach tagging rules https://github.com/mozilla/webmaker.org/commit/6226dab554c2b79a0a8ace3d730a09f30f1fc9cc Merge pull request #328 from daleee/886150-teach-tag-fixes [bug 886150] Standardizing /teach tagging rules
This is now implemented on production. Going to mark this resolved fixed!
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: