Closed Bug 886170 Opened 12 years ago Closed 12 years ago

Intermittent browser_dbg_bug723071_editor-breakpoints-highlight.js | The currently selected source is incorrect (0). - Got http://example.com/browser/browser/devtools/debugger/test/test-script-switching-02.js, expected ... and 11 more

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox24 fixed, firefox25 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 25
Tracking Flags:
Tracking Status
firefox24 --- fixed
firefox25 --- fixed

People

(Reporter: philor, Assigned: vporof)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

v1
30.99 KB, patch
past
: review+
bajaj
: approval-mozilla-beta+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=24494694&tree=Mozilla-Inbound Ubuntu VM 12.04 mozilla-inbound pgo test mochitest-browser-chrome on 2013-06-23 11:54:57 PDT for push 19675f2a58f5 slave: tst-linux32-ec2-035 12:11:22 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | Debugger has started 12:11:22 INFO - DBG-FRONTEND: Setting the DebuggerView editor source: http://example.com/browser/browser/devtools/debugger/test/test-script-switching-02.js, loaded: undefined 12:11:22 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The currently selected source is incorrect (0). - Got http://example.com/browser/browser/devtools/debugger/test/test-script-switching-02.js, expected http://example.com/browser/browser/devtools/debugger/test/test-script-switching-01.js 12:11:22 INFO - Stack trace: 12:11:22 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: initialChecks :: line 60 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: performTest :: line 39 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: _onEvent :: line 32 12:11:22 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 12:11:22 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The editor caret line was incorrect (0). 12:11:22 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The editor caret column was incorrect (0). 12:11:22 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The currently selected source is incorrect (0). - Got http://example.com/browser/browser/devtools/debugger/test/test-script-switching-02.js, expected http://example.com/browser/browser/devtools/debugger/test/test-script-switching-01.js 12:11:22 INFO - Stack trace: 12:11:22 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: initialChecks :: line 60 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: test/performTest/< :: line 41 12:11:22 INFO - JS frame :: chrome://browser/content/devtools/debugger-controller.js :: Breakpoints.prototype.addBreakpoint/< :: line 1389 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 1199 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 646 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 155 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DC_onPacket :: line 650 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/transport.js :: <TOP_LEVEL> :: line 236 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/DevToolsUtils.js :: <TOP_LEVEL> :: line 61 12:11:22 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 12:11:22 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The editor caret line was incorrect (0). 12:11:22 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The editor caret column was incorrect (0). 12:11:22 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The currently selected source is incorrect (0). - Got http://example.com/browser/browser/devtools/debugger/test/test-script-switching-02.js, expected http://example.com/browser/browser/devtools/debugger/test/test-script-switching-01.js 12:11:22 INFO - Stack trace: 12:11:22 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: initialChecks :: line 60 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: test/performTest/</< :: line 43 12:11:22 INFO - JS frame :: chrome://browser/content/devtools/debugger-controller.js :: Breakpoints.prototype.addBreakpoint/< :: line 1389 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 1201 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 646 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 155 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DC_onPacket :: line 650 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/transport.js :: <TOP_LEVEL> :: line 236 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/DevToolsUtils.js :: <TOP_LEVEL> :: line 61 12:11:22 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 12:11:22 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The editor caret line was incorrect (0). 12:11:22 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The editor caret column was incorrect (0). 12:11:22 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The currently selected source is incorrect (0). - Got http://example.com/browser/browser/devtools/debugger/test/test-script-switching-02.js, expected http://example.com/browser/browser/devtools/debugger/test/test-script-switching-01.js 12:11:22 INFO - Stack trace: 12:11:22 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: initialChecks :: line 60 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: test/performTest/</</< :: line 45 12:11:22 INFO - JS frame :: chrome://browser/content/devtools/debugger-controller.js :: Breakpoints.prototype.addBreakpoint/< :: line 1389 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 1199 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 646 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 155 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DC_onPacket :: line 650 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/transport.js :: <TOP_LEVEL> :: line 236 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/DevToolsUtils.js :: <TOP_LEVEL> :: line 61 12:11:22 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 12:11:22 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The editor caret line was incorrect (0). 12:11:22 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The editor caret column was incorrect (0). 12:11:22 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The currently selected source is incorrect (0). - Got http://example.com/browser/browser/devtools/debugger/test/test-script-switching-02.js, expected http://example.com/browser/browser/devtools/debugger/test/test-script-switching-01.js 12:11:22 INFO - Stack trace: 12:11:22 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: initialChecks :: line 60 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: test/performTest/</</</< :: line 47 12:11:22 INFO - JS frame :: chrome://browser/content/devtools/debugger-controller.js :: Breakpoints.prototype.addBreakpoint/< :: line 1389 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 1201 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 646 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 155 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DC_onPacket :: line 650 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/transport.js :: <TOP_LEVEL> :: line 236 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/DevToolsUtils.js :: <TOP_LEVEL> :: line 61 12:11:22 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 12:11:22 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The editor caret line was incorrect (0). 12:11:22 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The editor caret column was incorrect (0). 12:11:22 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The currently selected source is incorrect (0). - Got http://example.com/browser/browser/devtools/debugger/test/test-script-switching-02.js, expected http://example.com/browser/browser/devtools/debugger/test/test-script-switching-01.js 12:11:22 INFO - Stack trace: 12:11:22 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: initialChecks :: line 60 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: test/performTest/</</</</< :: line 49 12:11:22 INFO - JS frame :: chrome://browser/content/devtools/debugger-controller.js :: Breakpoints.prototype.addBreakpoint/< :: line 1389 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 1199 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 646 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 155 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DC_onPacket :: line 650 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/transport.js :: <TOP_LEVEL> :: line 236 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/DevToolsUtils.js :: <TOP_LEVEL> :: line 61 12:11:22 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 12:11:22 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The editor caret line was incorrect (0). 12:11:22 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The editor caret column was incorrect (0). 12:11:22 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The currently selected breakpoint item is incorrect. - Got undefined -> undefined, expected null 12:11:22 INFO - Stack trace: 12:11:22 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: checkHighlight :: line 179 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: testHighlight1 :: line 69 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: test/performTest/</</</</< :: line 50 12:11:22 INFO - JS frame :: chrome://browser/content/devtools/debugger-controller.js :: Breakpoints.prototype.addBreakpoint/< :: line 1389 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 1199 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 646 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 155 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DC_onPacket :: line 650 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/transport.js :: <TOP_LEVEL> :: line 236 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/DevToolsUtils.js :: <TOP_LEVEL> :: line 61 12:11:22 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 12:11:22 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The currently selected breakpoint client is incorrect. - Got [object Object], expected null 12:11:22 INFO - Stack trace: 12:11:22 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: checkHighlight :: line 181 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: testHighlight1 :: line 69 12:11:22 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: test/performTest/</</</</< :: line 50 12:11:22 INFO - JS frame :: chrome://browser/content/devtools/debugger-controller.js :: Breakpoints.prototype.addBreakpoint/< :: line 1389 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 1199 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 646 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45 12:11:22 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 155 12:11:22 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DC_onPacket :: line 650 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/transport.js :: <TOP_LEVEL> :: line 236 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/DevToolsUtils.js :: <TOP_LEVEL> :: line 61 12:11:23 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 12:11:23 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The selected breakpoint item's source location attachment is incorrect. - Got http://example.com/browser/browser/devtools/debugger/test/test-script-switching-01.js, expected http://example.com/browser/browser/devtools/debugger/test/test-script-switching-02.js 12:11:23 INFO - Stack trace: 12:11:23 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536 12:11:23 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: checkHighlight :: line 184 12:11:23 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: testHighlight1 :: line 69 12:11:23 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: test/performTest/</</</</< :: line 50 12:11:23 INFO - JS frame :: chrome://browser/content/devtools/debugger-controller.js :: Breakpoints.prototype.addBreakpoint/< :: line 1389 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 1199 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 646 12:11:23 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120 12:11:23 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45 12:11:23 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 155 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DC_onPacket :: line 650 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/transport.js :: <TOP_LEVEL> :: line 236 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/DevToolsUtils.js :: <TOP_LEVEL> :: line 61 12:11:23 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 12:11:23 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The selected breakpoint item's source line number is incorrect. - Got 9, expected 5 12:11:23 INFO - Stack trace: 12:11:23 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536 12:11:23 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: checkHighlight :: line 186 12:11:23 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: testHighlight1 :: line 69 12:11:23 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: test/performTest/</</</</< :: line 50 12:11:23 INFO - JS frame :: chrome://browser/content/devtools/debugger-controller.js :: Breakpoints.prototype.addBreakpoint/< :: line 1389 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 1199 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 646 12:11:23 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120 12:11:23 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45 12:11:23 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 155 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DC_onPacket :: line 650 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/transport.js :: <TOP_LEVEL> :: line 236 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/DevToolsUtils.js :: <TOP_LEVEL> :: line 61 12:11:23 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 12:11:23 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The selected breakpoint item's target should have a selected class. 12:11:23 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The currently selected source is incorrect (1). - Got http://example.com/browser/browser/devtools/debugger/test/test-script-switching-02.js, expected http://example.com/browser/browser/devtools/debugger/test/test-script-switching-01.js 12:11:23 INFO - Stack trace: 12:11:23 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536 12:11:23 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: testHighlight1 :: line 72 12:11:23 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js :: test/performTest/</</</</< :: line 50 12:11:23 INFO - JS frame :: chrome://browser/content/devtools/debugger-controller.js :: Breakpoints.prototype.addBreakpoint/< :: line 1389 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 1199 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 646 12:11:23 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120 12:11:23 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45 12:11:23 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 155 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DC_onPacket :: line 650 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/transport.js :: <TOP_LEVEL> :: line 236 12:11:23 INFO - JS frame :: resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/DevToolsUtils.js :: <TOP_LEVEL> :: line 61 12:11:23 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 12:11:23 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bug723071_editor-breakpoints-highlight.js | The editor caret line was incorrect (1).
This was introduced by bug 823577 - please may you take a look? :-)
Blocks: 823577
Flags: needinfo?(vporof)
Attached patch v1 — — Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #767155 - Flags: review?(past)
Flags: needinfo?(vporof)
If it fails, rewrite it to use promises.
Thank you for taking a look so quickly :-)
Comment on attachment 767155 [details] [diff] [review] v1 Review of attachment 767155 [details] [diff] [review]: ----------------------------------------------------------------- I support this change, but are you certain this will fix the test failures? What if the reason the expected files don't show up is that fetching times out? I guess we'll now see it in the log, and we can then tweak the timeout in the tests. OK, then! ::: browser/devtools/debugger/debugger-controller.js @@ +1003,5 @@ > * Gets a specified source's text. > * > * @param object aSource > * The source object coming from the active thread. > + * @param function aTimeout [optional] How about calling this aOnTimeout? Oh, and by the way, dcamp has said that we can choose not to follow the aName rule in devtools code. In case you care about that sort of thing. ::: browser/devtools/debugger/debugger-toolbar.js @@ +1467,2 @@ > let currentUrl = DebuggerView.Sources.selectedValue; > + aSources.sort(function([sourceUrl]) sourceUrl == currentUrl ? -1 : 1); Nitpicky, but I can't resist: arrow function?
Attachment #767155 - Flags: review?(past) → review+
(In reply to Panos Astithas [:past] from comment #11) > Comment on attachment 767155 [details] [diff] [review] > v1 > > Review of attachment 767155 [details] [diff] [review]: > ----------------------------------------------------------------- > > I support this change, but are you certain this will fix the test failures? > What if the reason the expected files don't show up is that fetching times > out? I guess we'll now see it in the log, and we can then tweak the timeout > in the tests. OK, then! > A combination of using promises and replacing ".values" with ".orderedItems" should do the trick. At least that's what I hope (what I'm saying is that I couldn't pinpoint the exact reason for the failures, but I suspect either weird unexpected asynchronicity, or the fact that ".values" doesn't actually return them in an always stably ordered fashion). > ::: browser/devtools/debugger/debugger-controller.js > @@ +1003,5 @@ > > * Gets a specified source's text. > > * > > * @param object aSource > > * The source object coming from the active thread. > > + * @param function aTimeout [optional] > > How about calling this aOnTimeout? > > Oh, and by the way, dcamp has said that we can choose not to follow the > aName rule in devtools code. In case you care about that sort of thing. > I know, but I try to keep the formatting and style of the file I modify. Nothing literally makes my eyes die more than seeing inconsistent style. That's why I never touch browser.js :) > ::: browser/devtools/debugger/debugger-toolbar.js > @@ +1467,2 @@ > > let currentUrl = DebuggerView.Sources.selectedValue; > > + aSources.sort(function([sourceUrl]) sourceUrl == currentUrl ? -1 : 1); > > Nitpicky, but I can't resist: arrow function? Yeah, okay :P
https://hg.mozilla.org/mozilla-central/rev/898abfaf7dc4
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
Can we request Aurora approval on this please?
Victor, can you please request approval to uplift to beta? Thanks :)
status-firefox24: --- → affected
status-firefox25: --- → fixed
Flags: needinfo?(vporof)
Yessir.
Flags: needinfo?(vporof)
Comment on attachment 767155 [details] [diff] [review] v1 [Approval Request Comment] Bug caused by (feature/regressing bug #): Some debugger tests are randomly failing, browser_dbg_bug723071_editor-breakpoints-highlight.js used to be a big culprit User impact if declined: No user impact, but sheriff's lives will be harder Testing completed (on m-c, etc.): fx-team, m-c, aurora Risk to taking this patch (and alternatives if risky): None, tested and straight forward changes to developer tools code. String or IDL/UUID changes made by this patch: None
Attachment #767155 - Flags: approval-mozilla-beta?
Attachment #767155 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #33) > https://hg.mozilla.org/releases/mozilla-beta/rev/017ad77a57ff Thanks for landing!
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: