886241 - IonMonkey: Enable inlined arguments_get_elem for constant index

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Hannes Verschore [:h4writer]]

Split of from bug 824622. I have a patch for a constant index, but since it was low priority I didn't push it yet. But I got some reports this is hit by people, so I better commit ;).

When inlining we know the arguments, so when an elem from the argument is requested, we can just return the right element.

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: Patch

Comment 2

[Hannes Verschore [:h4writer]]

Comment on attachment 766593 [details] [diff] [review]
Patch

Review of attachment 766593 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/IonBuilder.cpp
@@ +7072,5 @@
> +            current->push(inlineCallInfo_->getArg(id));
> +        } else {
> +            MConstant *undefined = MConstant::New(UndefinedValue());
> +            current->add(undefined);
> +            current->push(undefined);

Oh, this can be transformed to:
pushConstant(UndefinedValue());

Comment 3

[Hannes Verschore [:h4writer]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7e06e9a0a8d9

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7e06e9a0a8d9