Closed
Bug 886247
Opened 12 years ago
Closed 12 years ago
Move SVGAnimatedEnumeration to WebIDL
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
58.36 KB,
patch
|
dzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #766619 -
Flags: review?(dzbarsky)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 766619 [details] [diff] [review]
Patch v1
>+ NS_DECL_CYCLE_COLLECTING_ISUPPORTS
>+ NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS(SVGAnimatedEnumeration)
>+
>+ nsSVGElement* GetParentObject() const
>+ {
>+ return mSVGElement;
>+ }
Is this (or mSVGElement at all) used anywhere?
|
||
Comment 3•12 years ago
|
||
Comment on attachment 766619 [details] [diff] [review]
Patch v1
Review of attachment 766619 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/svg/content/src/SVGAnimatedEnumeration.cpp
@@ +21,5 @@
> + NS_WRAPPERCACHE_INTERFACE_MAP_ENTRY
> + NS_INTERFACE_MAP_ENTRY(nsIDOMSVGAnimatedEnumeration)
> + NS_INTERFACE_MAP_ENTRY(nsISupports)
> +NS_INTERFACE_MAP_END
> +
Followup to remove nsIDOMSVGAnimatedEnumeration?
Attachment #766619 -
Flags: review?(dzbarsky) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•