Closed Bug 886247 Opened 7 years ago Closed 7 years ago

Move SVGAnimatedEnumeration to WebIDL

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Attached patch Patch v1Splinter Review
Attachment #766619 - Flags: review?(dzbarsky)
Comment on attachment 766619 [details] [diff] [review]
Patch v1

>+  NS_DECL_CYCLE_COLLECTING_ISUPPORTS
>+  NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS(SVGAnimatedEnumeration)
>+
>+  nsSVGElement* GetParentObject() const
>+  {
>+    return mSVGElement;
>+  }

Is this (or mSVGElement at all) used anywhere?
Comment on attachment 766619 [details] [diff] [review]
Patch v1

Review of attachment 766619 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/SVGAnimatedEnumeration.cpp
@@ +21,5 @@
> +  NS_WRAPPERCACHE_INTERFACE_MAP_ENTRY
> +  NS_INTERFACE_MAP_ENTRY(nsIDOMSVGAnimatedEnumeration)
> +  NS_INTERFACE_MAP_ENTRY(nsISupports)
> +NS_INTERFACE_MAP_END
> +

Followup to remove nsIDOMSVGAnimatedEnumeration?
Attachment #766619 - Flags: review?(dzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/6c813cf67ed8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.