886385 - API returns "developed":true from search and "developed":false from app endpoint

Status: RESOLVED FIXED

(Marketplace Graveyard :: API, defect, P3)

Description

[Matt Basta [:basta]]

As a reviewer/admin, search for an app and visit the detail page. You'll see an Edit Listing button. Then refresh the page; the button is gone.

The first view gets the app object from the search API, the second gets it from the app API.

The response should be consistent between APIs.

Comment 1

[Rob Hudson [:robhudson]]

(In reply to Matt Basta [:basta] from comment #0)
> As a reviewer/admin, search for an app and visit the detail page. You'll see
> an Edit Listing button. Then refresh the page; the button is gone.
> 
> The first view gets the app object from the search API, the second gets it
> from the app API.
> 
> The response should be consistent between APIs.

Which one seems more correct?

The search uses this query:

    'developed': AddonUser.objects.filter(
                user=profile, role=amo.AUTHOR_ROLE_OWNER).exists(),

The app detail uses this query:

    'developed': app.has_author(profile, [amo.AUTHOR_ROLE_OWNER]),

Comment 2

[Christopher Van Wiemeersch [:cvan]]

The former is more semantically correct. But the latter allows us to check for 'developed' instead of 'developed' or 'reviewer' or 'admin'.

I'm okay with the latter; Basta filed this bug so he probably has an opinion. (Even if he didn't file the bug, I'm sure he has an opinion ;))

Comment 3

[Matt Basta [:basta]]

The former looks like it would be faster, let's go with that.

Comment 4

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/2db983f