886520 - Use xnest for running reftests

Status: NEW

(Testing :: Reftest, defect)

Description

[George Wright (:gw280) (needinfo me!)]

Reftests require that the Mozilla window has input focus; it'd be nice if on Linux, running "mach reftest" would automatically set up the xnest session for running them in.

Comment 1

[Mike Hommey [:glandium]]

xnest is obsolete. Use Xephyr. Or xvfb-run, it's actually just easier.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Does this have the same properties in terms of whether GPU acceleration is going to be enabled?  (Or is this intended to be done in a way that applies to developers but not to what happens on tinderbox?  If so... is that dangerous in terms of failures that might happen one way but not the other?)

Comment 3

[George Wright (:gw280) (needinfo me!)]

Hrm, good point. I have no idea if GLX is supported inside an Xnext (or xephyr or xvfb-run) session.

Comment 4

[George Wright (:gw280) (needinfo me!)]

Just checked and confirmed the Xephyr has glx. Would it make sense for "mach mochitest" to set up the xephyr session or should it be left up to devs to set up the xephyr session themselves?

I'd rather have the former, mainly because I always forget to do it :)

Comment 5

[Jeff Walden [:Waldo]]

The first, please.  Most people aren't going to have the time/interest in doing the latter.  The few that do can implement that customization in a followup.  ;-)

Comment 6

[(not currently active) Ted Mielczarek]

I'm pretty positive that zwol had patches to do this for Reftest or Mochitest at one point (related: bug 514067), but I don't know where they got off to. This also has some overlap with the work froydnj has been doing in bug 813742 and its prerequisites.

Comment 7

[(not currently active) Ted Mielczarek]

Aha! zwol's patch was on bug 434365.