886589 - Change - Add infrastructure for tapping center of elements rather than relying on hard-coded offsets

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Tests, defect, P3)

Description

[Jonathan Wilde [:jwilde]]

Some of the tests turn out to be really fragile in certain environments due to the use of magic numbers to tap more or less in the center of elements.

Sometimes the magic number offsets don't end up hitting in bounds of the element that we want to hit.

Comment 1

[Jonathan Wilde [:jwilde]]

Attachment: patch v1

Comment 2

[Jonathan Wilde [:jwilde]]

Attachment: patch v1.1 - better documentation

Comment 3

[Jonathan Wilde [:jwilde]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be5046383861

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/be5046383861

Comment 5

[juan becerra [:juanb]]

Jonathan, how would I go about verifying this? I tried going through the list of bugs for intermittent failures, but I can't see if there's a decline. Should there be?

Comment 6

[Jonathan Wilde [:jwilde]]

These changes won't really help with the intermittent issues.

They mainly help in ensuring that a developer won't break a test by changing the size of an element. I think everybody now runs the tests when developing/reviewing and catches test failures before landing. I'm really not sure how one would quantitatively verify this.

Comment 7

[Marco Mucci [:MarcoM]]

Should this be excluded from the regular QA regression testing?

Comment 8

[Marco Mucci [:MarcoM]]

Hey Jonathan, please see Comment #7.

Comment 9

[Jonathan Wilde [:jwilde]]

Given that this is exceedingly hard to support/refute whether this has indeed been fixed by the patches, I'd say that's probably a good plan.

Comment 10

[Marco Mucci [:MarcoM]]

Thanks.  I've removed it from the Metro testing sheet.