886711 - mailbloat doesn't have a timeout

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

We've currently got a failure on our debug builds in the "mailbloat" step, that means it never finishes. Unfortunately the mailbloat step doesn't have a timeout.

Hence the builds just keep running (I've just killed off somewhere around 40 builds across 2 platforms).

Attaching a patch. AFAICT Thunderbird is the only one that currently uses this special target, so it shouldn't affect anyone else.

I'm using a timeout of an hour, as that's what the Firefox leak tests use, and it seems reasonable.

Comment 1

[Justin Wood (:Callek)]

Comment on attachment 767076 [details] [diff] [review]
The fix

land on |default| at your discretion. The timeout can be tweaked later if need be. I should note of course that if we're already exceeding 4hours a lot, we're likely going to have lots of broken builds for TB after this lands. That said, a broken build we know about is better than an indefinitely running broken build we don't.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 767076 [details] [diff] [review]
The fix

https://hg.mozilla.org/build/buildbotcustom/rev/be6b890c39ad

Comment 3

[Kim Moir [:kmoir] ET]

In production