Closed
Bug 886728
Opened 12 years ago
Closed 12 years ago
Update DOCTYPE for HTML testcases to be HTML5 compliant
Categories
(Mozilla QA Graveyard :: Infrastructure, defect)
Mozilla QA Graveyard
Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: sushant)
References
Details
(Whiteboard: [mentor=whimboo][lang=html][good first bug])
Attachments
(1 file, 3 obsolete files)
|
25.94 KB,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
We have a couple of files in our testcase repository which contain old DOCTYPE declarations for transitional XHTML or others. We should update all of them so we are HTML5 compliant.
What you would have to do is to clone our testcase repository (http://hg.mozilla.org/qa/testcase-data/) and update the DOCTYPE declaration of affected files to '<!DOCTYPE html>'. Once done attach the patch to this bug and ask for review.
|
Assignee | |
Comment 1•12 years ago
|
||
I forgot to pull before creating this patch. So the html tags with lang and ltr is updated. I guess it must have been updated in the central repository as well by now. Atleast I hope so!
Attachment #767212 -
Flags: review?(hskupin)
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 767212 [details] [diff] [review]
Updated doctype of some older versions
Review of attachment 767212 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, but please make sure we have the DOCTYPE declaration added to all HTML documents. There are still a lot without any DOCTYPE.
Attachment #767212 -
Flags: review?(hskupin) → review-
|
|
Assignee | |
Comment 3•12 years ago
|
||
Ooh! I had thought of doing that earlier but then didn't do it. In this patch I just updated all the files which had any older version of doctype. I did not change files which did not have any doctype.
I'll update the remaining ones.
|
|
Assignee | |
Comment 4•12 years ago
|
||
Hope this is fine! :)
Attachment #767212 -
Attachment is obsolete: true
Attachment #767665 -
Flags: review?(hskupin)
|
|
Reporter | |
Updated•12 years ago
|
Assignee: nobody → hiraysushant
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 5•12 years ago
|
||
Comment on attachment 767665 [details] [diff] [review]
Patch:V2 Updated Doctype for all html files
Review of attachment 767665 [details] [diff] [review]:
-----------------------------------------------------------------
All files are covered now. But there is one thing you should fix. See my inline comment.
::: firefox/addons/install.html
@@ +1,1 @@
> +<!DOCTYPE html>
Something was wrong with your replacement. All lines across the files have a trailing white-space here.
Attachment #767665 -
Flags: review?(hskupin) → review-
|
|
Assignee | |
Comment 6•12 years ago
|
||
Attachment #767665 -
Attachment is obsolete: true
Attachment #768333 -
Flags: review?(hskupin)
|
|
Reporter | |
Comment 7•12 years ago
|
||
Comment on attachment 768333 [details] [diff] [review]
Removed Trailing whitespace from a file
Review of attachment 768333 [details] [diff] [review]:
-----------------------------------------------------------------
Sushant, sorry but my last review comments were about nearly all the files and not only that single one.
Attachment #768333 -
Flags: review?(hskupin) → review-
|
|
Assignee | |
Comment 8•12 years ago
|
||
My bad.I was wondering how come only a single file had a trailing w/s since I updated all the files by a script!
I'll update that shortly!
|
|
Assignee | |
Comment 9•12 years ago
|
||
Attachment #768333 -
Attachment is obsolete: true
Attachment #768415 -
Flags: review?(hskupin)
|
|
Reporter | |
Comment 10•12 years ago
|
||
Comment on attachment 768415 [details] [diff] [review]
v4: Removed trailing whitespace from *.html
Review of attachment 768415 [details] [diff] [review]:
-----------------------------------------------------------------
Looks great. All files are covered now. Only one hint for the future... When updating the commit message of the patch please make sure to follow the guidelines from https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F. I will update it this time.
Thanks for the patch! If you want to help with something else please let me know.
Attachment #768415 -
Flags: review?(hskupin) → review+
|
|
Reporter | |
Comment 11•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 12•12 years ago
|
||
I'll make sure that I write appropriate commit messages!
I would surely love to help further. I will look into the Bug:886734 for a start.
Regards,
Sushant
|
||
Updated•7 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•