886738 - System update notification too narrow for most localizations

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: Screenshot of Unagi (build 2013-06-25)

it
Aggiornamento di sistema + Obbligatorio

es
Actualización del sistema + Obligatoria

pt-BR
Atualização do sistema + Obrigatória

Any change to change the layout of this screen without having to use abbreviations in the localization?

Comment 1

[Alex Keybl [:akeybl]]

Not a blocker, but clee would really like this for koi

Comment 2

[Jason Smith [:jsmith]]

Not blocking - not critical for 1.2.

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Comparison (before/after patch, short/long text)

Comparison on Keon with patch applied

Comment 4

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

Some notes on these changes (lines in the previous image are to see the differences between current and patched).

I'm dropping li.nosize rule, because it seems logical based on the other changes, but I don't know how to test that.

"REQUIRED" is slightly lower than the original, which seems a bit off to me. It could be restored using 3.3rem instead of 3.4rem.

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 8391131 [details] [review]
Pull request on Github

(In reply to Francesco Lodolo [:flod] from comment #4)
> I'm dropping li.nosize rule, because it seems logical based on the other
> changes, but I don't know how to test that.

Sadly we still need it :/
It's possible to have an app update where we don't know the size.
And in this case, we still want to align the first line with the checkbox.
(I'll attach a screenshot).

> 
> "REQUIRED" is slightly lower than the original, which seems a bit off to me.

Looks good!
Thanks for cleaning this up, once we get the .nosize back we'll be good to go.

Comment 6

[Etienne Segonzac (:etienne)]

Attachment: nosize example

Comment 7

[Francesco Lodolo [:flod]]

Attachment: Comparison for no size updates (before/after patch, fake long text)

Comment 8

[Francesco Lodolo [:flod]]

Comment on attachment 8391131 [details] [review]
Pull request on Github

Updated patch.

Thanks for the tip to text unkwown size updates. Basically I was right about the existing rules not being necessary anymore, but I had no idea the text was originally aligned with the checkbox.

Comment 9

[Etienne Segonzac (:etienne)]

Comment on attachment 8391131 [details] [review]
Pull request on Github

Looking good, r=me with the (now dead) code to add the .nosize class removed [1].

Sadly, you won't have to update any tests, because this was not covered :/

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/update_manager.js#L263

Comment 10

[Francesco Lodolo [:flod]]

Thanks, setting checkin-needed

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Master: 63205a83fe2793ae902015dd92bd1b3a9193360d

Comment 12

[Francesco Lodolo [:flod]]

Verified on Keon with build 2014-03-25