Closed Bug 886812 Opened 11 years ago Closed 11 years ago

[STK] Opening settings only for some commands

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

RESOLVED FIXED
blocking-b2g leo+
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: frsela, Assigned: frsela)

References

Details

(Whiteboard: QARegressExclude)

Attachments

(1 file)

After STK refactoring settings app is opened when the received command is not recognized by system

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/icc.js#L85

Now, all STK commands are in the icc_worker.js file and we only need to open settings on SELECT_ITEM command, so we should move it to here:

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/icc_worker.js#L217
Assignee: nobody → frsela
Blocks: 875679
blocking-b2g: --- → leo?
Depends on: 886810
Fernando, can you provide an estimate of risk here for taking this?
Also can you explain why SELECT_ITEM requires opening the settings app?
Flags: needinfo?(frsela)
(In reply to Wayne Chang [:wchang] from comment #2)
> Fernando, can you provide an estimate of risk here for taking this?

Very low. Without this patch, Settings will be opened by any command non managed by system (after refactor, only SELECT_ITEM)

With the patch, the code is more clear since the settings open method is INSIDE the worker for this command

> Also can you explain why SELECT_ITEM requires opening the settings app?

SELECT_ITEM is used by STK to NAVIGATE through the app menus and this navigation continue living in Settings.

It's not very normal to receive a SELECT_ITEM command non SOLICITED but if we receive it, we should open the STK app and show the menu (in settings)
Flags: needinfo?(frsela)
Blocking as this is one of the fallouts form the refactoring and low risk .
blocking-b2g: leo? → leo+
Comment on attachment 767663 [details]
Settins is opened only when SELECT_ITEM is executed

Please lint and make sure Travis-CI is green before submit for review.
Attachment #767663 - Flags: review?(timdream)
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #5)
> Comment on attachment 767663 [details]
> Settins is opened only when SELECT_ITEM is executed
> 
> Please lint and make sure Travis-CI is green before submit for review.
Fixed
Attachment #767663 - Flags: review?(timdream)
Attachment #767663 - Flags: review?(timdream) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Hi John,

Could you please help us on uplifting this patch to V1-train?, we need to unblock STK/ICC testing on V1-train. Thanks!
Flags: needinfo?(jhford)
Uplifted e8191bf269b90480fe69b68f63a16a79f13dfcd7 to:
v1-train: 54bb73f257dc0432febf11f8442cee34600e8b51
v1.1.0hd: 54bb73f257dc0432febf11f8442cee34600e8b51
Flags: needinfo?(jhford)
Whiteboard: QARegressExclude
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: