886812 - [STK] Opening settings only for some commands

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

After STK refactoring settings app is opened when the received command is not recognized by system

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/icc.js#L85

Now, all STK commands are in the icc_worker.js file and we only need to open settings on SELECT_ITEM command, so we should move it to here:

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/icc_worker.js#L217

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Settins is opened only when SELECT_ITEM is executed

Comment 2

[Wayne Chang [:wchang]]

Fernando, can you provide an estimate of risk here for taking this?
Also can you explain why SELECT_ITEM requires opening the settings app?

Comment 3

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Wayne Chang [:wchang] from comment #2)
> Fernando, can you provide an estimate of risk here for taking this?

Very low. Without this patch, Settings will be opened by any command non managed by system (after refactor, only SELECT_ITEM)

With the patch, the code is more clear since the settings open method is INSIDE the worker for this command

> Also can you explain why SELECT_ITEM requires opening the settings app?

SELECT_ITEM is used by STK to NAVIGATE through the app menus and this navigation continue living in Settings.

It's not very normal to receive a SELECT_ITEM command non SOLICITED but if we receive it, we should open the STK app and show the menu (in settings)

Comment 4

[bhavana bajaj [:bajaj]]

Blocking as this is one of the fallouts form the refactoring and low risk .

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 767663 [details]
Settins is opened only when SELECT_ITEM is executed

Please lint and make sure Travis-CI is green before submit for review.

Comment 6

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #5)
> Comment on attachment 767663 [details]
> Settins is opened only when SELECT_ITEM is executed
> 
> Please lint and make sure Travis-CI is green before submit for review.
Fixed

Comment 7

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed: https://github.com/mozilla-b2g/gaia/commit/e8191bf269b90480fe69b68f63a16a79f13dfcd7

Comment 8

[Noemí Freire (:noemi)]

Hi John,

Could you please help us on uplifting this patch to V1-train?, we need to unblock STK/ICC testing on V1-train. Thanks!

Comment 9

[Gareth Aye [:gaye] (back from PTO)]

Uplifted e8191bf269b90480fe69b68f63a16a79f13dfcd7 to:
v1-train: 54bb73f257dc0432febf11f8442cee34600e8b51

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 54bb73f257dc0432febf11f8442cee34600e8b51