886829 - In-source comments incorrectly say JSClass::finalizer is mandatory

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

While we're at it, we could also assert that the things that are in fact mandatory are not null.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Proposed change

So it turns out this situation doesn't arise at the moment.  Rather than doing an extra check, we can just assert that it doesn't happen and add it later if necessary.

Comment 2

[Jon Coppeard (:jonco)]

(In reply to Jon Coppeard (:jonco) from comment #1)

Please ignore previous comment, which was intended for a different bug!

As stated originally, change documentation and assert mandatory members.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 767779 [details] [diff] [review]
Proposed change

Review of attachment 767779 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsclass.h
@@ +210,2 @@
>                                                                                \
>      /* Optionally non-null members start here. */                             \

"Optionally non-null" sounds a bit odd to my ear. Maybe "These members can be null."?

Comment 4

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/68cb015e3e21

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/68cb015e3e21
https://hg.mozilla.org/mozilla-central/rev/3184e72d56af