Closed
Bug 886916
Opened 11 years ago
Closed 11 years ago
Regression: Multiple-level settings screens do not handle "back" correctly
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox23 verified, firefox24 verified, firefox25 verified)
VERIFIED
FIXED
Firefox 25
People
(Reporter: liuche, Assigned: liuche)
Details
Attachments
(4 files, 2 obsolete files)
3.01 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
3.27 KB,
patch
|
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
3.23 KB,
patch
|
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
3.24 KB,
patch
|
Details | Diff | Splinter Review |
In adding link handling for bug 879558, I broke back behavior for nested settings. Attaching a patch to create a new result code and not overload use of Activity.RESULT_CANCELED. inbound try build: https://tbpl.mozilla.org/?tree=Try&rev=389c706b3327
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Aurora try build: https://tbpl.mozilla.org/?tree=Try&rev=7e17d66a8cc8
Attachment #767345 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #767348 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 4•11 years ago
|
||
Beta try build: https://tbpl.mozilla.org/?tree=Try&rev=88551a15686a
Assignee | ||
Updated•11 years ago
|
Attachment #767343 -
Flags: review?(rnewman) → review?(mark.finkle)
Assignee | ||
Updated•11 years ago
|
Attachment #767343 -
Flags: review?(mark.finkle) → review?(margaret.leibovic)
Assignee | ||
Updated•11 years ago
|
Attachment #767345 -
Flags: review?(mark.finkle) → review?(margaret.leibovic)
Assignee | ||
Updated•11 years ago
|
Attachment #767348 -
Flags: review?(mark.finkle) → review?(margaret.leibovic)
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 767345 [details] [diff] [review] Aurora patch: add new result code [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 879558 User impact if declined: users manually navigating through Settings > Data Choices will be returned to browser screen on hitting back, instead of one level up the menu Testing completed (on m-c, etc.): manual confirm of regression and fix of m-a Risk to taking this patch (and alternatives if risky): very low, replaces a constant in an existing code path String or IDL/UUID changes made by this patch: none
Attachment #767345 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 767348 [details] [diff] [review] Beta patch: Add new result code for GeckoPreferences [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 879558 User impact if declined: users manually navigating through Settings > Data Choices will be returned to browser screen on hitting back, instead of one level up the menu Testing completed (on m-c, etc.): manual confirm of regression and fix of m-b Risk to taking this patch (and alternatives if risky): very low, replaces a constant in an existing code path String or IDL/UUID changes made by this patch: none
Attachment #767348 -
Flags: approval-mozilla-beta?
Comment 7•11 years ago
|
||
Comment on attachment 767343 [details] [diff] [review] Inbound patch: add new result Review of attachment 767343 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/GeckoPreferences.java @@ +75,5 @@ > private static String PREFS_GEO_REPORTING = "app.geo.reportdata"; > private static String PREFS_HEALTHREPORT_LINK = NON_PREF_PREFIX + "healthreport.link"; > > private static int REQUEST_CODE_PREF_SCREEN = 5; > + private static int RESULT_CODE_EXIT_SETTINGS = 6; Nit: Add a comment about why you chose these values. @@ +208,5 @@ > > @Override > public void onActivityResult(int requestCode, int resultCode, Intent data) { > + if (REQUEST_CODE_PREF_SCREEN == requestCode && RESULT_CODE_EXIT_SETTINGS == resultCode) { > + setResult(RESULT_CODE_EXIT_SETTINGS); Nit: I know this is already in the current code, but it would be nice to add a comment here about why we're setting the result with what already appears to be the resultCode.
Attachment #767343 -
Flags: review?(margaret.leibovic) → review+
Updated•11 years ago
|
Attachment #767345 -
Flags: review?(margaret.leibovic) → review+
Updated•11 years ago
|
Attachment #767348 -
Flags: review?(margaret.leibovic) → review+
Assignee | ||
Comment 8•11 years ago
|
||
[Approval Request Comment] Bug caused by (feature/regressing bug #): bug 879558 User impact if declined: users manually navigating through Settings > Data Choices will be returned to browser screen on hitting back, instead of one level up the menu Testing completed (on m-c, etc.): manual confirm of regression and fix of m-b Risk to taking this patch (and alternatives if risky): very low, replaces a constant in an existing code path String or IDL/UUID changes made by this patch: none
Attachment #767348 -
Attachment is obsolete: true
Attachment #767348 -
Flags: approval-mozilla-beta?
Attachment #767424 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 9•11 years ago
|
||
[Approval Request Comment] Bug caused by (feature/regressing bug #): bug 879558 User impact if declined: users manually navigating through Settings > Data Choices will be returned to browser screen on hitting back, instead of one level up the menu Testing completed (on m-c, etc.): manual confirm of regression and fix of m-a Risk to taking this patch (and alternatives if risky): very low, replaces a constant in an existing code path String or IDL/UUID changes made by this patch: none
Attachment #767345 -
Attachment is obsolete: true
Attachment #767345 -
Flags: approval-mozilla-aurora?
Attachment #767427 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 10•11 years ago
|
||
Assignee | ||
Comment 11•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/05ba2e9812df
Comment 12•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/05ba2e9812df
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Updated•11 years ago
|
Attachment #767427 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•11 years ago
|
Attachment #767424 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee | ||
Comment 13•11 years ago
|
||
Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/67b0221cbd69 Beta: https://hg.mozilla.org/releases/mozilla-beta/rev/eaa8c8b1731b
Updated•11 years ago
|
Comment 14•10 years ago
|
||
Verified as fixed in build: Firefox 23; Device: Asus Transformer Tab (Android 4.0.3).
Keywords: verifyme
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•