886939 - Download arrow animation is cut off by toolbar

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Markus Stange [:mstange]]

Attachment: screenshot

The download arrow animation that appears when a download completes is cut off by the edges of the toolbar.

It looks like this was caused by bug 865926, which added this rule:

toolbar[overflowable] > .customization-target {
  overflow: hidden;
}

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

In order to keep this working, we'll probably have to do the animation outside of the toolbar. I'm not sure how tricky that will be though.

Mike, you've been looking at doing overlay things with highlighting findbar results. Do you think you could use that experience to look in to this?

Comment 2

[Mike de Boer [:mikedeboer]]

Sure, but the overlays were made easy in that case, because the <browser> is inside a <stack>. But that doesn't mean a similar approach can't be done in this case without a stack.
I can put this on my list to work on.

Comment 3

[:Gijs (out for now; he/him)]

The vertical crop should disappear now that the fix for bug 876871 is checked in. However, a horizontal crop will remain if the button is at either end of the toolbar until we fix this properly. Mike, did you look at this already?

Comment 4

[Mike de Boer [:mikedeboer]]

no, I wasn't able to do that. Only thing I could think of while investigating this is to reparent the 'downloads-indicator-notification' vbox to outside the toolbar and correct its position before animating. But that's not trivial.

Comment 5

[:Gijs (out for now; he/him)]

This is fixed by bug 922847