Closed
Bug 886949
Opened 12 years ago
Closed 12 years ago
Add Number.parseInt and Number.parseFloat
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla25
| Tracking | Status | |
|---|---|---|
| relnote-firefox | --- | - |
People
(Reporter: bbenvie, Assigned: till)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, Whiteboard: [qa-])
Attachments
(1 file)
|
9.20 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
In ES6, `Number.parseInt` and `Number.parseFloat` have been added, and are the same as the global functions of the same names (purpose is modularization of globals).
See ES6 spec (May 2013 revision) sections 15.7.3.9 and 15.7.3.10.
| Assignee | ||
Comment 1•12 years ago
|
||
This is all very straight-forward.
As these are meant to behave identical to their global function counterparts, I just added them to number_static_methods.
In case they ever deviate from the global functions in any way, the duplicated tests should catch any errors that might otherwise sneak in.
Attachment #771686 -
Flags: review?(jwalden+bmo)
| Assignee | ||
Updated•12 years ago
|
Assignee: general → till
Updated•12 years ago
|
Attachment #771686 -
Flags: review?(jwalden+bmo) → review+
| Assignee | ||
Comment 2•12 years ago
|
||
Status: NEW → ASSIGNED
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Updated•12 years ago
|
Keywords: dev-doc-needed
Updated•12 years ago
|
relnote-firefox:
--- → ?
Assuming this does not need QA. Please remove the [qa-] whiteboard tag and add the verifyme keyword if QA is needed.
Whiteboard: [qa-]
Updated•12 years ago
|
Comment 5•12 years ago
|
||
Added to "Firefox 25 for developer" release notes:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/25#JavaScript
Updated reference docs:
Added to: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number
New: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/parseFloat
New: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/parseInt
As always, feel free to review and/or edit these pages in the MDN wiki.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•