887051 - Fix gamepad action key behavior in AwesomeScreen

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Brian Nicholson (:bnicholson)]

There are a couple of bugs that make the AwesomeScreen unusable with the gamepad:

1) Clicking an entry in the AllPagesTab list simply closes the AwesomeScreen instead of actually going to the URL that was clicked.
2) If focus is taken away from the URL EditText and it gains focus again, clicking the action button should bring up the keyboard so the text can be changed. Instead, it does a search and closes the AwesomeScreen.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Fix gamepad action key behavior in AwesomeScreen

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: Fix gamepad action key behavior in AwesomeScreen, v2

The first bug listed above was actually the side effect of bug 876765, where I added another OnKeyDownListener to the ListView and replaced the ListItemClickDispatcher. But I think we still want this change so that other views in the AwesomeBar still handle the action key correctly; for example, without bubbling this event, the keyboard isn't shown when the URL EditText is clicked. This approach also fixes long press clicks on the list view to show the context menu. Since this uses the standard Android key event handling, we don't need the ListItemClickDispatcher at all.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 767877 [details] [diff] [review]
Fix gamepad action key behavior in AwesomeScreen, v2

Review of attachment 767877 [details] [diff] [review]:
-----------------------------------------------------------------

Tested this and it works fine. LGTM!

Comment 4

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01928dac9556

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/01928dac9556