Closed
Bug 887068
Opened 12 years ago
Closed 12 years ago
SimplePush: webapps-uninstall uses _request that was renamed to _sendRequest
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
People
(Reporter: nsm, Assigned: nsm)
References
Details
(Whiteboard: [fixed-in-birch][qa-])
Attachments
(1 file)
|
1.07 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
This will cause PushService to error when an app with active registrations is uninstalled, so asking for blocker. Patch coming up.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #767509 -
Flags: review?(doug.turner)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 767509 [details] [diff] [review]
Fix
Review of attachment 767509 [details] [diff] [review]:
-----------------------------------------------------------------
rs=dougt
Attachment #767509 -
Flags: review?(doug.turner) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Whiteboard: [fixed-in-birch]
|
||
Comment 4•12 years ago
|
||
Is the error a silent one? Is there error visual to user? Can this cause problems on server?
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
|
||
Comment 6•12 years ago
|
||
(In reply to Dietrich Ayala (:dietrich) from comment #4)
> Is the error a silent one? Is there error visual to user? Can this cause
> problems on server?
Please Nikhil, answer above questions. Triagers need the info to set the suitable flag.
Flags: needinfo?(nsm.nikhil)
|
|
Assignee | |
Comment 7•12 years ago
|
||
(In reply to Dietrich Ayala (:dietrich) from comment #4)
> Is the error a silent one? Is there error visual to user? Can this cause
> problems on server?
It is a silent one as far as the user is concerned at that point. But since the error is thrown, the PushService will stop working, rendering future push unusable until the phone is restarted.
No problems on the server.
Flags: needinfo?(nsm.nikhil)
|
||
Updated•12 years ago
|
blocking-b2g: leo? → leo+
|
||
Comment 8•12 years ago
|
||
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → wontfix
status-b2g-v1.1hd:
--- → affected
status-firefox23:
--- → wontfix
status-firefox24:
--- → wontfix
status-firefox25:
--- → fixed
|
|
||
Comment 9•12 years ago
|
||
|
||
Comment 10•11 years ago
|
||
Assuming this does not need QA.
Whiteboard: [fixed-in-birch] → [fixed-in-birch][qa-]
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•