887069 - Fix focus behavior of go button in URL bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

The go button in the AwesomeScreen needs a focus state so it's obvious that it has focus. Also, clicking left on the d-pad from the go button should go back to the URL EditText, but it instead moves down to the opt-in prompt buttons.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Fix focus behavior of go button in URL bar

Fixes the problems mentioned above.

Also, I'm not sure what these empty LinearLayouts are for. Removing them seems to have no effect, so we should drop them unless they actually serve a purpose.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 767530 [details] [diff] [review]
Fix focus behavior of go button in URL bar

Review of attachment 767530 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with that.

::: mobile/android/base/resources/layout/awesomebar_search.xml
@@ +46,3 @@
>      <ImageButton android:id="@+id/awesomebar_button"
>                   style="@style/AddressBar.ImageButton.Icon"
> +                 android:background="@drawable/action_bar_button"

Move it to be below padding. OCD :D

Comment 3

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f9bd80f2b4d

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5f9bd80f2b4d

Comment 5

[u421692]

Verified fixed on:
Build: Firefox for Android 25.0a1(2013-07-07)
Device: LG Nexus 4
OS: Android 4.2.2