Closed Bug 887069 Opened 11 years ago Closed 11 years ago

Fix focus behavior of go button in URL bar

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 25

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

Attachments

(1 file)

The go button in the AwesomeScreen needs a focus state so it's obvious that it has focus. Also, clicking left on the d-pad from the go button should go back to the URL EditText, but it instead moves down to the opt-in prompt buttons.
Fixes the problems mentioned above.

Also, I'm not sure what these empty LinearLayouts are for. Removing them seems to have no effect, so we should drop them unless they actually serve a purpose.
Attachment #767530 - Flags: review?(sriram)
Comment on attachment 767530 [details] [diff] [review]
Fix focus behavior of go button in URL bar

Review of attachment 767530 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with that.

::: mobile/android/base/resources/layout/awesomebar_search.xml
@@ +46,3 @@
>      <ImageButton android:id="@+id/awesomebar_button"
>                   style="@style/AddressBar.ImageButton.Icon"
> +                 android:background="@drawable/action_bar_button"

Move it to be below padding. OCD :D
Attachment #767530 - Flags: review?(sriram) → review+
https://hg.mozilla.org/mozilla-central/rev/5f9bd80f2b4d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Verified fixed on:
Build: Firefox for Android 25.0a1(2013-07-07)
Device: LG Nexus 4
OS: Android 4.2.2
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: