Closed Bug 887116 Opened 7 years ago Closed 7 years ago

Get rid of contentutils refcounting in CallbackObject

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: bzbarsky, Assigned: nsm)

References

Details

Attachments

(1 file, 1 obsolete file)

Assignee: nobody → nsm.nikhil
Blocks: 904826
Comment on attachment 789809 [details] [diff] [review]
Don't hold a reference to nsLayoutStatics in WebIDL CallbackObject.

Review of attachment 789809 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/CallbackObject.h
@@ +96,5 @@
>      MOZ_ASSERT(aCallback && !mCallback);
>      // Set mCallback before we hold, on the off chance that a GC could somehow
>      // happen in there... (which would be pretty odd, granted).
>      mCallback = aCallback;
>      // Make sure we'll be able to drop as needed

You should drop this comment, as it refers to the AddRef().
https://hg.mozilla.org/mozilla-central/rev/1803c6a790ae
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Is there a reason the nsLayoutStatics.h include wasn't removed too?
Flags: needinfo?(nsm.nikhil)
I think it actually breaks a bunch of stuff that was bootlegging in nsThreadUtils.h.  I'm working on removing it (and others) in bug 904826.
Flags: needinfo?(nsm.nikhil)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.