Closed Bug 887133 Opened 11 years ago Closed 11 years ago

[Camera] flash icon orientation not changing

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Camera
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

Status:
RESOLVED FIXED
Milestone:
1.1 QE3 (26jun)
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: leo.bugzilla.gaia, Assigned: leo.bugzilla.gaia)

Details

(Whiteboard: [enhancement] [LeoVB+])

Attachments

(1 file, 1 obsolete file)

Pointer to pull request
195 bytes, text/html
daleharvey
: review+
Details 
1. Title : Flash Icon orientation
2. Precondition : Camera app should be working
3. Tester's Action : 1. Open camera
                     2. Rotate phone from portrait to landscape and vice versa
 
4. Detailed Symptom (ENG.) : Orientation of flash icon doesnot change with the orientation of the phone


5. Expected : Orientation of flash icon should change with the orientation of the phone.

6.Reproducibility: Y
1)Frequency Rate : 100%
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: 65e861f5941cab66815a2f79b0bc0a6a0fc8f6fe
9.Personal email id: gjyothiprasad@gmail.com
Attached file Pointer to pull request (obsolete) — 
toggle-flash has to be rotated along with phone's orientation change.

Hi Dale,
Please review the patch
Assignee: nobody → leo.bugzilla.gaia
Attachment #767621 - Flags: review?(dale)
blocking-b2g: --- → leo?
Target Milestone: --- → 1.1 QE3 (26jun)
Hi Dale,

I have added toggle-camera along with toggle-flash.
Please review the patch.
Attachment #767621 - Attachment is obsolete: true
Attachment #767621 - Flags: review?(dale)
Attachment #767662 - Flags: review?(dale)
Attachment #767662 - Flags: review?(dale) → review+
Cheers, merged in: https://github.com/mozilla-b2g/gaia/commit/ae9a2882ef50ffc19112b52044e698a364fdbf8f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
blocking-b2g: leo? → -
Whiteboard: [enhancement]
blocking-b2g: - → leo+
Uplifted ae9a2882ef50ffc19112b52044e698a364fdbf8f to:
v1-train: 92dc24633bbc2e83292e68d38fa741a0ac291f95
status-b2g18: --- → fixed
Whiteboard: [enhancement] → [enhancement] [LeoVB+]
v1.1.0hd: 92dc24633bbc2e83292e68d38fa741a0ac291f95
status-b2g-v1.1hd: --- → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: