887158 - [SMS] DOMRequest change to an array of [DOMRequest].

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Leo]

1. Title: The device produces a noise after interrupting the call.
2. Precondition: SMS app should be working
3. Tester's Action: 1. Dial -> Make a voice call -> The support handset does    not answer the call
          2.Wait a few seconds, then stop the voice call before it be answered
          3.Check the behavior.
4. Detailed Symptom (ENG.) : The device produces a noise after interrupting the call.
5. Expected: The handset should not produce any noise after interrupting the call.
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train: Reproduced on v1-train
8. Gaia Revision:f2d6ed54a236e6e3b94f0abad9f0dacb8a1cc7b3
9. Personal email id: [e-mail]

Comment 1

[Leo]

Attachment: Video Attached

Comment 2

[Leo]

Attachment: Log file attached

Please check the video and log file for the issue.

Comment 3

[Leo]

Attachment: Video Attached

Comment 4

[Anthony Ricaud (:rik)]

I can't reproduce this. Maybe it needs more preconditions.

Also, when looking at the logs, I see a 'hiddenmenu' app.  This app doesn't exist in the Gaia code base. It seems to be launched by the dialer app. Maybe it's this app that plays the sound? Is the code of this app available somewhere?

Comment 5

[Wayne Chang [:wchang]]

qawanted on this. Please check the attached video.

I wonder if this has to do with the usage app?

Comment 6

[Leo]

Hi Anthony,
There is no precondition for this defect.
The information we got is that after call is released, the SALDO message is sent to 8000 and because of this there is a noise appearing after the call.
Thanks,

Comment 7

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 8

[Borja Salguero [:borjasalguero]]

After talking with Steve we are going to modify the name of this bug, because the 'sound' issue was fixed with @lodr patch. This one will be fixing the DOMRequest thing.

Comment 9

[Steve Chung [:steveck]]

Comment on attachment 768156 [details]
Pull Request

Hi Borja, I agree that we should fix the dom request problem, but I think this bug might be fixed by bug 880395. We need to confirm that whether we should play the sound only when the message is in the current view or every time when message sent. Thanks.

Comment 10

[Borja Salguero [:borjasalguero]]

Code updated! :)

Comment 11

[Steve Chung [:steveck]]

Comment on attachment 768156 [details]
Pull Request

This Dom request fixing looks good to me. Thanks.

Comment 12

[Steve Chung [:steveck]]

Land in master: 8162952be9d4577f58a6815c92c4e51e5e132d85

Comment 13

[Gareth Aye [:gaye] (back from PTO)]

Uplifted 8162952be9d4577f58a6815c92c4e51e5e132d85 to:
v1-train: 349d3f6ee87b00d5c1ed1fc2165e219390878132

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 349d3f6ee87b00d5c1ed1fc2165e219390878132